Skip to content

CCM-14410: Make the eventpub lambda handle unknown plane values#152

Merged
gareth-allan merged 1 commit intomainfrom
feature/CCM-14410_eventpub_handle_unknown_plane_values
Mar 2, 2026
Merged

CCM-14410: Make the eventpub lambda handle unknown plane values#152
gareth-allan merged 1 commit intomainfrom
feature/CCM-14410_eventpub_handle_unknown_plane_values

Conversation

@gareth-allan
Copy link
Copy Markdown
Contributor

@gareth-allan gareth-allan commented Feb 27, 2026

Description

This PR adds a check to the eventpub module's lambda to identify events which have a plane field that does not match either data or control, and to DLQ these events rather than silently dropping them as it does now.

Context

I spotted that events with an incorrect plane value could potentially be silently dropped when investigating how the eventpub module could be used to send events to the shared event bus. Note that events with a completely missing plane field would fail the validation step, so are already being DLQed.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@gareth-allan gareth-allan marked this pull request as ready for review February 27, 2026 11:21
@gareth-allan gareth-allan requested a review from a team as a code owner February 27, 2026 11:21
@gareth-allan gareth-allan merged commit 70181eb into main Mar 2, 2026
45 checks passed
@gareth-allan gareth-allan deleted the feature/CCM-14410_eventpub_handle_unknown_plane_values branch March 2, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants