CCM-14410: Make the eventpub lambda handle unknown plane values#152
Merged
gareth-allan merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
aidenvaines-cgi
approved these changes
Mar 2, 2026
m-houston
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check to the eventpub module's lambda to identify events which have a
planefield that does not match eitherdataorcontrol, and to DLQ these events rather than silently dropping them as it does now.Context
I spotted that events with an incorrect plane value could potentially be silently dropped when investigating how the eventpub module could be used to send events to the shared event bus. Note that events with a completely missing
planefield would fail the validation step, so are already being DLQed.Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.