PPHA-671: Add question to change text in hidden span#382
Open
jamiefalcus wants to merge 2 commits intomainfrom
Open
PPHA-671: Add question to change text in hidden span#382jamiefalcus wants to merge 2 commits intomainfrom
jamiefalcus wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility on the “Check your answers” page by adding additional hidden context to “Change” links so screen-reader users can better understand what each link relates to.
Changes:
- Add
visuallyHiddenTextto summary-list action items generated byResponseSetPresenter. - Add a visually-hidden description to the per-smoking-type “Change” link in
responses.jinja. - Minor Terraform locals alignment/formatting.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
lung_cancer_screening/questions/presenters/response_set_presenter.py |
Adds hidden text metadata to “Change” action links in summary list rows. |
lung_cancer_screening/questions/jinja2/responses.jinja |
Adds a visually-hidden span to clarify the “Change” link for smoking-history sections. |
infrastructure/terraform/spoke/variables.tf |
Formatting-only alignment in locals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lung_cancer_screening/questions/presenters/response_set_presenter.py
Outdated
Show resolved
Hide resolved
jamiefalcus
changed the title
jamiefalcus
force-pushed
the
PPHA-671-change-link-hidden-description
branch
from
949ccab to
8be8a45
Compare
stephhou
reviewed
Mar 19, 2026
stephhou
approved these changes
Mar 19, 2026
jamiefalcus
force-pushed
the
PPHA-671-change-link-hidden-description
branch
from
8be8a45 to
f03abd5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Add hidden description test to change links on check your answers
Why are we making this change?
Allows those using screen readers to more easily know what the change link is referring to