PPHA-671: Review changes

Author: jamiefalcus

lung_cancer_screening/questions/jinja2/responses.jinja

@@ -56,7 +56,7 @@
             "questions:smoking_current",
             kwargs={ "tobacco_type": type_history.url_type() },
             query={ "change": "True" },
-          ) }}" class="nhsuk-link" >Change <span class="visually-hidden">your answers to {{ type_history.title() }} smoking history</span></a>
+          ) }}" class="nhsuk-link" >Change<span class="nhsuk-u-visually-hidden"> your answers to {{ type_history.title() }} smoking history</span></a>
 
           {{ summaryList({
             "rows": type_history.summary_items()

lung_cancer_screening/questions/presenters/response_set_presenter.py

@@ -311,7 +311,7 @@ def _check_your_answer_item(self, question, value, url_lookup_name, kwargs = {})
                     {
                         "href": reverse(url_lookup_name, kwargs = kwargs, query = self._change_query_params()),
                         "text": "Change",
-                        "visuallyHiddenText": f"answer for {question.lower()}"
+                        "visuallyHiddenText": f"answer for {question.lower().rstrip("?")}"
                     }
                 ]
             }

lung_cancer_screening/questions/tests/unit/presenters/test_response_set_presenter.py

@@ -459,3 +459,14 @@ def test_tobacco_smoking_history_by_type_returns_presenter_grouped_by_type(self)
 
         self.assertEqual(type(result[0]), TobaccoSmokingHistoryTypePresenter)
         self.assertEqual(type(result[1]), TobaccoSmokingHistoryTypePresenter)
+
+    @tag("CheckYourAnswers")
+    def test_check_your_answer_item_has_visually_hidden_text(self):
+        presenter = ResponseSetPresenter(self.response_set)
+
+        answers_item = presenter._check_your_answer_item("Have you ever smoked?", "Not answered", "questions:have_you_ever_smoked")
+
+        self.assertEqual(
+            answers_item["actions"]["items"][0]["visuallyHiddenText"],
+            "answer for have you ever smoked"
+        )