Skip to content

[NRL-1922] Fixup more Sonarqube issues#1159

Merged
mattdean3-nhs merged 13 commits intodevelopfrom
feature/made14-NRL-1922-moooore-sonarqube-beefs
Mar 20, 2026
Merged

[NRL-1922] Fixup more Sonarqube issues#1159
mattdean3-nhs merged 13 commits intodevelopfrom
feature/made14-NRL-1922-moooore-sonarqube-beefs

Conversation

@mattdean3-nhs
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs commented Mar 4, 2026

Fixes include:

  • Forcing TLS for curl usage in scripts
  • Using a commit hash for external actions in workflows
  • Removing TODOs
  • Marking all S3 bucket with NOSONAR to ignore log config warnings
  • Having a specific stand-alone bucket policy for the HTTPSOnly rule
  • Not hard-coding region in the scripts
  • Not using mutable defaults in python function args
  • Adding some unit tests for coverage of changes in pipeline.py
  • Marking all automated apt installs with NOSONAR to allow non-interactive installs

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

🚀 PR environment successfully deployed.
Commit Hash: 702eac96938958c413ba2af47eec6ba6406c397f
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

🚀 PR environment successfully deployed.
Commit Hash: 6f62863fe5d2b77a953ec417d73985265cd4fe03
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

🚀 PR environment successfully deployed.
Commit Hash: babb2484db007ecc43b8a61c8a0aeb92f246f8d1
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

🚀 PR environment successfully deployed.
Commit Hash: 2de2f453993ee12adfac48547dd82be39ad7a185
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 0b856531b2a13d82a5406a7677b3ef1c86a53b7c
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 0c47f751527e7c8c692dbbf7f00247ad3b9c1fe3
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: c4b22b0f4bc8e202c88b50f8a2c0bf03b4edb591
URL: https://nrl1922-01ba47.api.record-locator.dev.national.nhs.uk/

@mattdean3-nhs mattdean3-nhs merged commit 9e90f3f into develop Mar 20, 2026
11 checks passed
@mattdean3-nhs mattdean3-nhs deleted the feature/made14-NRL-1922-moooore-sonarqube-beefs branch March 20, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants