Skip to content

NRL-2060 Restore missing permissions logs#1173

Merged
anjalitrace2-nhs merged 2 commits intodevelopfrom
NRL-2060-realign-logs
Mar 19, 2026
Merged

NRL-2060 Restore missing permissions logs#1173
anjalitrace2-nhs merged 2 commits intodevelopfrom
NRL-2060-realign-logs

Conversation

@anjalitrace2-nhs
Copy link
Contributor

@anjalitrace2-nhs anjalitrace2-nhs commented Mar 18, 2026

When adding in v2 permissions in #1159 I got a little enthusiastic and removed a couple super handy logs from v1 permissions. These are required for power BI reporting and handy investigation queries.
This PR reinstates those missing logs for v1 and, where possible, reuses the existing log references in v2 rather than creating similar versions bespoke to v2.

  • Restore HANDLER002 & HANDLER003 to v1 and add to v2
  • Correct a HANDLER004b -> HANDLER004a (oops!)
  • Reuse existing HANDLER004* logs & make messages clearer
  • Keep new v2 specific logs which have no v1 equivalent (e.g. "Using v2 perms" + V2PERMISSIONS* better logging around retrieving perm file from lambda)
  • Remove now-unused log references

@sonarqubecloud
Copy link

@anjalitrace2-nhs anjalitrace2-nhs changed the title NRL-2060 add missing logs back in NRL-2060 Restore missing logs for permissions v1 & v2 Mar 18, 2026
@anjalitrace2-nhs anjalitrace2-nhs changed the title NRL-2060 Restore missing logs for permissions v1 & v2 NRL-2060 Restore missing permissions logs Mar 18, 2026
@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 3a82c2a61790883af406daecf4aecb0d08f0d83b
URL: https://nrl2060-01ba47.api.record-locator.dev.national.nhs.uk/

@anjalitrace2-nhs anjalitrace2-nhs merged commit 78bb5fd into develop Mar 19, 2026
11 checks passed
@anjalitrace2-nhs anjalitrace2-nhs deleted the NRL-2060-realign-logs branch March 19, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants