Some extra search filtering and aggregations#850
Conversation
gunnarvelle
force-pushed
the
draft-responsibles
branch
from
0db1166 to
42b1c26
Compare
draft-api/src/main/scala/no/ndla/draftapi/controller/DraftController.scala
Outdated
Show resolved
Hide resolved
draft-api/src/main/scala/no/ndla/draftapi/service/search/ArticleSearchService.scala
Outdated
Show resolved
Hide resolved
gunnarvelle
force-pushed
the
draft-responsibles
branch
2 times, most recently
from
f43f37e to
d260001
Compare
draft-api/src/main/scala/no/ndla/draftapi/service/ReadService.scala
Outdated
Show resolved
Hide resolved
draft-api/src/main/scala/no/ndla/draftapi/service/WriteService.scala
Outdated
Show resolved
Hide resolved
gunnarvelle
force-pushed
the
draft-responsibles
branch
2 times, most recently
from
7571b13 to
3957ee1
Compare
gunnarvelle
force-pushed
the
draft-responsibles
branch
2 times, most recently
from
ed30402 to
5ebf3f6
Compare
gunnarvelle
changed the title
There was a problem hiding this comment.
Nå har jeg funnet en del steder hvor det mangler refresh av responsible og user ID views'ene 😅 Så jeg lurer på om det egentlig hadde vært enklere med enten en cronjobb, eller databasetrigger av noe slag, som refresh'er view'ene i stedet for å måtte holde styr på det i koden?
Har ikke testa noe av dette, men her er noen forslag fra chattern 😄 https://chatgpt.com/share/e/69b2a2ca-1c20-8015-b296-eca3012aea05
draft-api/src/main/resources/no/ndla/draftapi/db/migration/V84__UserIdsMaterializedView.sql
Show resolved
Hide resolved
| created = clock.now(), | ||
| published = clock.now(), | ||
| updatedBy = userInfo.id, | ||
| responsible = newResponsible, |
There was a problem hiding this comment.
Her må vel også responsible_view refresh'es?
There was a problem hiding this comment.
Samme gjelder vel user_ids_view
| fileStorage.copyResource(withoutPrefix, newFileName).map(f => s"/files/$f") | ||
| } | ||
|
|
||
| def newArticle(newArticle: api.NewArticleDTO, user: TokenUser): Try[api.ArticleDTO] = { |
There was a problem hiding this comment.
Her må også responsible og user IDs refresh'es?
| } | ||
| } | ||
|
|
||
| def updateArticleStatus(status: DraftStatus, id: Long, user: TokenUser): Try[api.ArticleDTO] = dbUtility |
There was a problem hiding this comment.
Her ser det også ut til at responsible må refresh'es
search-api/src/main/scala/no/ndla/searchapi/service/search/MultiDraftSearchService.scala
Outdated
Show resolved
Hide resolved
gunnarvelle
force-pushed
the
draft-responsibles
branch
from
86c30a2 to
5f205a8
Compare
| else booleanMust("contexts.rootId", subjectId) | ||
| ) | ||
| Some(mustBeConceptOr(nestedQuery("contexts", boolQuery().should(subjectQueries)).ignoreUnmapped(true))) | ||
| protected def subjectFilter(subjects: Option[List[String]], filterInactive: Boolean): Option[Query] = { |
There was a problem hiding this comment.
Vet ikke hvordan frontend gjør det i dag, men om den alltid sender tom liste (i stedet for å ikke sende parameter), så er dette breaking. Tenker fortsatt det kan være nice å endre, må bare passe på å endre frontend også i så fall 😄
There was a problem hiding this comment.
Meiner graphql-api fjerner parametre som er undefined slik at den blir None så antar dette er trygt. Men skal sjekke.
search-api/src/main/scala/no/ndla/searchapi/service/search/MultiDraftSearchService.scala
Outdated
Show resolved
Hide resolved
3 participants
Litt forskjellig fra https://trello.com/c/J05Ep4B2/1590-justeringer