Make Parcel Names Unique#1825
Merged
Merged
Conversation
- also goes through and adds (1), (2), ...etc, to parcels with duplicate names
Mythicaeda
added
fix
dandelany
approved these changes
May 8, 2026
Collaborator
There was a problem hiding this comment.
Looks good, tested including local migration (up AND down, since we made a mistake the first time!) Only (minor, nonbreaking) issue is UI - for future reference:
- We should have a better error message for this case to make it clear why it failed - just says "Failed"
- Ideally should revert the unsaved text to the last saved name and not gray out the save button on unsuccessful save.
I'll wrap these into a future UI issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a uniqueness constraint to parcel names in the DB.
The up migration will automatically deduplicate parcel names, repeating the process until there are no more duplicate names.
Note: I've set this PR's migration to one higher than #1822, as I expect that PR to be merged first.
Verification
I manually set up a DB where there with multiple parcels with unique names, multiple parcels named
parcel, and a parcel namedparcel(1)(which is the deduplication naming pattern). I then ran the DB migration via the Python script and observed that conflicting names were correctly deduplicated.