Fix Edge Case in Anchor Validation#1822
Merged
Merged
Conversation
Mythicaeda
added
test
Mythicaeda
force-pushed
the
fix/anchor-validation
branch
from
cca1ac3 to
df07bc1
Compare
Mythicaeda
force-pushed
the
fix/anchor-validation
branch
from
df07bc1 to
d62a91b
Compare
Mythicaeda
added
refactor
Before, when checking whether an activity had a negative offset relative to plan_start, it would skip activities that had a positive start offset, even if their total offset was negative (ie, due to the activity it was anchored to having a large negative offset).
Tests now: - are better commented - use JUnit's "assertThrows" instead of try-catch - are more direct - have shared setup code pulled out into the BeforeEach
dandelany
force-pushed
the
fix/anchor-validation
branch
from
dd0b83a to
a244fb2
Compare
…egative net offset
AaronPlave
approved these changes
May 8, 2026
Contributor
AaronPlave
left a comment
AaronPlave
left a comment
There was a problem hiding this comment.
@dandelany and I tested this locally and added one e2e test.
Collaborator
|
Merging so i can get tests running on #1825 - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the "activity is before plan start" validation check would skip activities that did not have a negative start offset. This would cause it to fail to mark activities as "out of bounds" in the case where it had a positive offset to its out-of-bounds parent anchor, but not enough of a positive offset to put it back inside plan bounds. The logic has been fixed to check all start time anchors, not just negative start time anchors.
Verification
A new test was added to AnchorTests that goes over the formerly-buggy edge case:
NetNegativePlanStartStatus.indirectlyInvalidChildAdditionally, the AnchorTests have been refactored, with a focus on making them more direct and better commented. See the second commit for a more thorough list of changes.