Return Violation Messages from Constraints#1782
Merged
Merged
Conversation
Mythicaeda
changed the title
Mythicaeda
had a problem deploying
to
e2e-test
GitHub Actions
Failure
Mythicaeda
requested review from
dandelany
and removed request for
adrienmaillard and
joshhaug
Mythicaeda
added
fix
Mythicaeda
force-pushed
the
fix/return-violation-messages
branch
from
0240389 to
4b59937
Compare
Mythicaeda
had a problem deploying
to
e2e-test
GitHub Actions
Failure
Mythicaeda
had a problem deploying
to
e2e-test
GitHub Actions
Failure
Mythicaeda
force-pushed
the
fix/return-violation-messages
branch
from
4b59937 to
bd47d81
Compare
dandelany
force-pushed
the
fix/return-violation-messages
branch
from
bd47d81 to
0395e1a
Compare
Mythicaeda
commented
Apr 20, 2026
Mythicaeda
force-pushed
the
fix/return-violation-messages
branch
from
0395e1a to
4f25d56
Compare
dandelany
approved these changes
May 9, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
👍 this looks good, reviewed code & tested locally by running FruitThresholdConstraint and finding constraint message in the DB. We'll work on hooking up the UI for this soon, but this PR can merge whenever.
While the constraints are run according to their priority, because the results did not have that guarantee, causing flakiness in E2ETests
Mythicaeda
force-pushed
the
fix/return-violation-messages
branch
from
30b2e1a to
338a6f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a Procedural Constraint has a message on a Violation, it is now included alongside the
windowsandactivityIdfields.The changes match those in the ticket, except one more file was updated:
actions.graphqlwas also updated so that Hasura is aware of this new optional field.Verification
A new test was added to
BasicConstraintTests:messageReturnedIfPresent. It runs the constraintsFruitThresholdConstraint(which has been updated to include a violation message) andNoMessageConstraint(a new constraint that is equivalent toFruitThresholdConstraint, except it does not contain a message) and shows that themessage` field is now populated if the Violation contained a message.Documentation
The API example for checking constraints should be updated to include the new field.
Done, PR is here.
Future work
The UI needs to be update to display these messages, if they are present.