Skip to content

UI for constraint violation messages#1928

Merged
dandelany merged 3 commits into
developfrom
dev/constraint-violation-messages
May 12, 2026
Merged

UI for constraint violation messages#1928
dandelany merged 3 commits into
developfrom
dev/constraint-violation-messages

Conversation

@dandelany
Copy link
Copy Markdown
Collaborator

___REQUIRES_AERIE_PR___="1782"

Description

This adds basic UI in two places for supporting the new Constraint violation messages now returned by the backend in NASA-AMMOS/plandev#1782

  • Requests the new message field on constraint violations from the CheckConstraints gql response
  • Shows violation messages in the timeline hover tooltip when hovering over red violation ranges
  • Filters timeline hover payloads down to the specific violation windows under the cursor, so overlapping violations can show the right message(s)
  • Shows violation messages under violation time ranges in the constraints panel when present

Verification

  • Unit test for violations panel: src/components/constraints/ConstraintViolationButton.svelte.test.ts
  • manual testing:
    1. In the plandev repo, check out the fix/return-violation-messages branch and run ./gradlew e2eTest:buildAllProcedureJars to build the example constraint JARs
    2. Run this version of the UI, go to Constraints page and upload a JAR constraint, use e2e-tests/build/libs/FruitThresholdConstraint.jar
    3. Make an example plan using the banananation mission model, go to Constraints panel -> Manage Constraints and add the "FruitThresholdConstraint"
    4. Run sim and check constraints to get a violation.
    5. You should see the message "fruit count is outside of boundaries" in the Constraints panel under Violations and in the violation tooltip
    6. Repeat with more violations if you want to test multiple/overlapping messages
image

@dandelany dandelany requested a review from AaronPlave May 9, 2026 04:05
@dandelany dandelany requested a review from a team as a code owner May 9, 2026 04:05
@dandelany dandelany requested review from duranb and mattdailis May 9, 2026 04:05
@dandelany dandelany temporarily deployed to test-workflow May 9, 2026 04:05 — with GitHub Actions Inactive
@dandelany dandelany changed the title Dev/constraint violation messages UI for constraint violation messages May 9, 2026
@dandelany dandelany temporarily deployed to test-workflow May 9, 2026 04:05 — with GitHub Actions Inactive
@dandelany dandelany removed the request for review from mattdailis May 9, 2026 08:01
@AaronPlave AaronPlave added the feature New feature or request label May 11, 2026
Copy link
Copy Markdown
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and works nicely.

@dandelany
Copy link
Copy Markdown
Collaborator Author

Thanks! Merging this, backend has already merged.

@dandelany dandelany merged commit 06c08ac into develop May 12, 2026
7 checks passed
@dandelany dandelany deleted the dev/constraint-violation-messages branch May 12, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants