fix: use relative paths inside pip package (drop ../YCB_sim/ prefix)#1
Merged
Conversation
includes/*.xml referenced meshes and textures via ../YCB_sim/meshes/ and ../YCB_sim/textures/. When installed as a pip package the sibling YCB_sim/ directory does not exist — the actual assets are at ../meshes/ and ../textures/ relative to the includes/ subdirectory. Fixes path resolution when ycb_sim is imported from a virtual environment without a git-submodule checkout of the full repo tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
includes/*.xmlfiles reference meshes and textures via../YCB_sim/meshes/and../YCB_sim/textures/. When installed as a pip package, the siblingYCB_sim/directory does not exist — MuJoCo cannot resolve these paths and asset loading fails at runtime.Fix
Replace
../YCB_sim/with../in allincludes/*.xmlfiles. From theincludes/subdirectory,../meshes/and../textures/correctly resolve to the package root'smeshes/andtextures/directories.Impact
This is required for
ycb_simto work when installed via pip without a full git-submodule checkout. Without this fix, downstream consumers (e.g. MyoSuite) must apply runtime XML patching to rewrite these paths on every model load.