Skip to content

chore(ci): node24 setup-node + fix fuzz_bootstrap flake8 false positive #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lallaria merged 1 commit into from
Jun 5, 2026
Merged

chore(ci): node24 setup-node + fix fuzz_bootstrap flake8 false positive #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unittests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
steps:
- uses: actions/checkout@v6
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: '22'
- name: Install dependencies
Expand Down
12 changes: 7 additions & 5 deletions GitHubLib/fuzz-image/fuzz_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
# imports `worlds.*` (which would otherwise pull the real index from GitHub).
# See MWClone ModuleUpdate.py for the SKIP_ALL_INSTALLS short-circuit; the shim
# below provides the GameIndex surface that Utils.set_game_names depends on.
os.environ["SKIP_ALL_INSTALLS"] = "1"
# os/sys/ap_path are owned by the host fuzz.py at the splice point; this fragment
# is never run standalone, so flake8's F821 on those names is suppressed per-line.
os.environ["SKIP_ALL_INSTALLS"] = "1" # noqa: F821

import argparse as _bootstrap_argparse
import json as _bootstrap_json
Expand All @@ -27,15 +29,15 @@
# Spawn workers re-import the module with sys.argv = ['-c', ...] —
# argparse sees nothing, so fall back to an env var the parent sets.
_games = _pre_args.game or [
s for s in os.environ.get("APFUZZ_GAMES", "").split(",") if s
s for s in os.environ.get("APFUZZ_GAMES", "").split(",") if s # noqa: F821
]
if _games:
os.environ["APFUZZ_GAMES"] = ",".join(_games)
os.environ["APFUZZ_GAMES"] = ",".join(_games) # noqa: F821

_name_to_slug: dict = {}
if _games:
_search_roots = [
_BootstrapPath(ap_path) / "worlds",
_BootstrapPath(ap_path) / "worlds", # noqa: F821
_BootstrapPath(_bootstrap_sysconfig.get_paths()["purelib"]) / "worlds",
]
for _slug in _games:
Expand Down Expand Up @@ -92,7 +94,7 @@
_shim_path = _BootstrapPath(_bootstrap_sysconfig.get_paths()["purelib"]) / "mwgg_igdb.py"
_shim_path.write_text(_shim_src, encoding="utf-8")
_bootstrap_importlib.invalidate_caches()
sys.modules.pop("mwgg_igdb", None)
sys.modules.pop("mwgg_igdb", None) # noqa: F821

if _games:
from Utils import set_game_names
Expand Down
Loading