chore(ci): node24 setup-node + fix fuzz_bootstrap flake8 false positive#43
Merged
Conversation
…F821 actions/setup-node@v4 runs on the deprecated node20 runtime (force-migrated 2026-06-16); @v5 uses node24. It was the only node20 action left in .github/workflows. fuzz_bootstrap.py is sed-spliced into upstream fuzz.py, so os/sys/ap_path are host-owned — the blocking flake8 --select=E9,F63,F7,F82 step flagged them as F821. Suppress per-line; a file-level # flake8: noqa silences the whole file in flake8 7.x. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small CI-greenness fixes (no runtime behavior change).
setup-node → v5 (node24)
actions/setup-node@v4runs on the node20 action runtime, which GitHub deprecated and force-migrates to node24 on 2026-06-16. It was the only node20-runtime action left across.github/workflows/. Bumped to@v5(node24).node-version: '22'(the Node that runs vitest) is unchanged; there's nopackageManagerfield inWebHostLib/static/js-tests/package.json, so v5's auto-caching doesn't kick in.fuzz_bootstrap.py F821
GitHubLib/fuzz-image/fuzz_bootstrap.pyis a fragmentsed-spliced into upstreamfuzz.py(seerun_fuzz.sh), never run standalone. Itsos,sys, andap_pathreferences are owned by the hostfuzz.pyat the splice point, so the blockingflake8 --select=E9,F63,F7,F82step inanalyze-modified-files.ymlflags them as F821 (undefined name) whenever the file is in a diff. Suppressed per-line with# noqa: F821. A file-level# flake8: noqa: F821was avoided — in flake8 7.x it silences the entire file regardless of the listed code, which would mask real future issues.Verified locally: the exact blocking flake8 command now exits 0 on the file.
🤖 Generated with Claude Code