1.1.7 #164
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| { | ||||||
| "name": "@metamask/snap-simple-keyring-site", | ||||||
| "version": "1.1.7", | ||||||
|
There was a problem hiding this comment. What are your thoughts on bumping the version to 2.0.0 rather than 1.1.7? Obviously there aren't any breaking changes in this release, but as it is 1.1.7 will be the initial version of the package, and since this is a special case where previously we were pushing changes to GitHub but now we are also pushing new versions to NPM, perhaps the initial version of the NPM package should be something a little less random.
Suggested change
Member
There was a problem hiding this comment. hi there 👋 ohh that's a great point. I've created a new branch because I rely the create release workflow for creating the PR. |
||||||
| "description": "A snap simple keyring dapp used in MetaMask e2e tests.", | ||||||
| "license": "(MIT-0 OR Apache-2.0)", | ||||||
| "scripts": { | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [1.1.7] | ||
|
|
||
| ### Changed | ||
|
|
||
| - Bump `crypto-browserify@^3.12.1` + `snaps-*` ([#159](https://github.com/MetaMask/snap-simple-keyring/pull/159)) | ||
|
|
||
| ## [1.1.6] | ||
|
|
||
| ### Changed | ||
|
|
@@ -158,7 +164,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| - Initial release. | ||
|
|
||
| [Unreleased]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.7...HEAD | ||
| [1.1.7]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.6...v1.1.7 | ||
| [1.1.6]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.5...v1.1.6 | ||
| [1.1.5]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.4...v1.1.5 | ||
| [1.1.4]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.3...v1.1.4 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "@metamask/snap-simple-keyring-snap", | ||
| "version": "1.1.7", | ||
| "description": "A simple keyring snap that integrates with MetaMask accounts.", | ||
| "keywords": [ | ||
| "metamask", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| { | ||
| "version": "1.1.7", | ||
| "description": "An example of a key management snap for a simple keyring.", | ||
| "proposedName": "MetaMask Simple Snap Keyring", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/MetaMask/snap-simple-keyring.git" | ||
| }, | ||
| "source": { | ||
| "shasum": "v3NGZZ5pEu7Y14geQjYsFAh5MoCUzY8fQLmbwQnFmAE=", | ||
| "location": { | ||
| "npm": { | ||
| "filePath": "dist/bundle.js", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we choose to release the site package as 2.0.0, should we bump this to a big value? This version doesn't really matter as it's not visible to users, it's really just used to tell the GitHub workflows that we have a new release available. But for other monorepos like
coreandsnapswe have always bumped the major for the root package whenever there is a new release. And this "root version" doesn't have to be kept in sync with a particular package. So, in order to avoid confusion in the future and change the process a bit, perhaps this should be something like 50.0.0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm I'm hesitant to differ the 2 versions because I'm unsure if this will impact the Github Action flow for creating the PR release candidates 🤔