1.1.7 #164
1.1.7 #164
Conversation
| { | ||
| "name": "@metamask/snap-simple-keyring", | ||
| "version": "1.1.6", | ||
| "version": "1.1.7", |
There was a problem hiding this comment.
If we choose to release the site package as 2.0.0, should we bump this to a big value? This version doesn't really matter as it's not visible to users, it's really just used to tell the GitHub workflows that we have a new release available. But for other monorepos like core and snaps we have always bumped the major for the root package whenever there is a new release. And this "root version" doesn't have to be kept in sync with a particular package. So, in order to avoid confusion in the future and change the process a bit, perhaps this should be something like 50.0.0?
| "version": "1.1.7", | |
| "version": "50.0.0", |
There was a problem hiding this comment.
mmm I'm hesitant to differ the 2 versions because I'm unsure if this will impact the Github Action flow for creating the PR release candidates 🤔
| { | ||
| "name": "@metamask/snap-simple-keyring-site", | ||
| "version": "1.1.6", | ||
| "version": "1.1.7", |
There was a problem hiding this comment.
What are your thoughts on bumping the version to 2.0.0 rather than 1.1.7? Obviously there aren't any breaking changes in this release, but as it is 1.1.7 will be the initial version of the package, and since this is a special case where previously we were pushing changes to GitHub but now we are also pushing new versions to NPM, perhaps the initial version of the NPM package should be something a little less random.
| "version": "1.1.7", | |
| "version": "2.0.0", |
There was a problem hiding this comment.
hi there 👋 ohh that's a great point. I've created a new branch because I rely the create release workflow for creating the PR.
New branch is here
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [1.1.7] |
There was a problem hiding this comment.
(Accompanies the suggestion below)
| ## [1.1.7] | |
| ## [2.0.0] |
| [Unreleased]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.7...HEAD | ||
| [1.1.7]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.6...v1.1.7 |
There was a problem hiding this comment.
(Accompanies the suggestion below)
| [Unreleased]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.7...HEAD | |
| [1.1.7]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.6...v1.1.7 | |
| [Unreleased]: https://github.com/MetaMask/snap-simple-keyring/compare/v2.0.0...HEAD | |
| [1.1.7]: https://github.com/MetaMask/snap-simple-keyring/compare/v1.1.6...v2.0.0 |
This is the release candidate for version 1.1.7.
Note
Bumps all packages to 1.1.7, updates changelogs, and refreshes the snap manifest shasum with minor site and dependency updates.
1.1.7in rootpackage.json,packages/site/package.json,packages/snap/package.json, andpackages/snap/snap.manifest.json.1.1.7entries inpackages/site/CHANGELOG.mdandpackages/snap/CHANGELOG.md; update[Unreleased]links.@metamask/snap-simple-keyring-sitepublishable, using CentraNo1 font, and bumpingcrypto-browserify@^3.12.1andsnaps-*.source.shasumtov3NGZZ5pEu7Y14geQjYsFAh5MoCUzY8fQLmbwQnFmAE=.Written by Cursor Bugbot for commit 299bc80. This will update automatically on new commits. Configure here.