Skip to content

Support TypeScript 5.6.x-5.8.x #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 6 commits into from
Apr 15, 2025
Merged

Support TypeScript 5.6.x-5.8.x #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
852a659
Support TypeScript 5.6.x-5.8.x
mcmire Mar 21, 2025
1e23503
Update versions of typescript and typescript-eslint in README
mcmire Mar 24, 2025
e62f292
Merge branch 'main' into bump-typescript
mcmire Mar 24, 2025
fe16e3d
Recommend ~ instead of ^ to protect against breakages
mcmire Mar 24, 2025
c9af88b
Bump TypeScript in the root package to 5.8, and bump typescript-eslin…
mcmire Mar 24, 2025
2dfe437
Merge branch 'main' into bump-typescript
mcmire Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
"globals": "^15.9.0",
"prettier": "^3.3.3",
"prettier-plugin-packagejson": "^2.5.2",
"typescript": "~5.5.4",
"typescript-eslint": "^8.24.0",
"typescript": "~5.8.0",
"typescript-eslint": "^8.28.0",
"vite": "^5.4.12",
"vitest": "^2.1.9"
},
Expand Down
5 changes: 3 additions & 2 deletions packages/typescript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ yarn add --dev \
eslint-plugin-jsdoc@^50.2.4 \
eslint-plugin-prettier@^5.2.1 \
eslint-plugin-promise@^7.1.0 \
prettier@^3.3.3
typescript-eslint@^8.6.0
prettier@^3.3.3 \
typescript@~5.8.0 \
typescript-eslint@^8.28.0
```

The order in which you extend ESLint rules matters.
Expand Down
8 changes: 4 additions & 4 deletions packages/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
"eslint-plugin-prettier": "^5.2.1",
"globals": "^15.9.0",
"prettier": "^3.3.3",
"typescript": "~5.5.4",
"typescript-eslint": "^8.24.0",
"typescript": "~5.8.0",
"typescript-eslint": "^8.28.0",
"vitest": "^2.1.9"
},
"peerDependencies": {
Expand All @@ -58,8 +58,8 @@
"eslint-import-resolver-typescript": "^3.6.3",
"eslint-plugin-import-x": "^4.3.0",
"eslint-plugin-jsdoc": "^50.2.4",
"typescript": ">=4.8.4 <5.6",
"typescript-eslint": "^8.24.0"
"typescript": ">=4.8.4 <5.9.0",
Copy link
Copy Markdown
Contributor Author

@mcmire mcmire Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really trying not to inconvenience existing projects this time around...

"typescript-eslint": "^8.24"
Copy link
Copy Markdown
Contributor Author

@mcmire mcmire Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that we could give consumers more flexibility for this package given that sometimes new versions bump the peer dependency on typescript and some don't.

},
"engines": {
"node": "^18.18 || >=20"
Expand Down
Loading
Loading