Conversation
This change allows us to upgrade to the latest version of TypeScript in all of our projects. `typescript-eslint` 8.24.0-8.27.x are also supported.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "typescript": ">=4.8.4 <5.6", | ||
| "typescript-eslint": "^8.24.0" | ||
| "typescript": ">=4.8.4 <5.9.0", | ||
| "typescript-eslint": "^8.24" |
There was a problem hiding this comment.
I figured that we could give consumers more flexibility for this package given that sometimes new versions bump the peer dependency on typescript and some don't.
| "eslint-plugin-jsdoc": "^50.2.4", | ||
| "typescript": ">=4.8.4 <5.6", | ||
| "typescript-eslint": "^8.24.0" | ||
| "typescript": ">=4.8.4 <5.9.0", |
There was a problem hiding this comment.
Really trying not to inconvenience existing projects this time around...
Mrtenz
left a comment
There was a problem hiding this comment.
Can you update the README of @metamask/eslint-config-typescript as well to use the new version?
|
Should we upgrade TypeScript all around in this PR? I'm just updating the dev depependency in the |
@mcmire Sounds good to me! |
|
Feedback addressed. Ready for another review. |
This commit loosens the peer restriction on
typescriptto allow projects to upgrade to more recent versions of TypeScript (such as 5.8, the latest version at the time of writing). Similarly, the peer restriction ontypescript-eslinthas been loosened to support more recent versions.Both of these packages have been updated in development as well.