Skip to content

Support TypeScript 5.6.x-5.8.x#395

Merged
mcmire merged 6 commits intomainfrom
bump-typescript
Apr 15, 2025
Merged

Support TypeScript 5.6.x-5.8.x#395
mcmire merged 6 commits intomainfrom
bump-typescript

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Mar 21, 2025

This commit loosens the peer restriction on typescript to allow projects to upgrade to more recent versions of TypeScript (such as 5.8, the latest version at the time of writing). Similarly, the peer restriction on typescript-eslint has been loosened to support more recent versions.

Both of these packages have been updated in development as well.

This change allows us to upgrade to the latest version of TypeScript in
all of our projects.

`typescript-eslint` 8.24.0-8.27.x are also supported.
@mcmire mcmire requested review from a team as code owners March 21, 2025 17:33
"typescript": ">=4.8.4 <5.6",
"typescript-eslint": "^8.24.0"
"typescript": ">=4.8.4 <5.9.0",
"typescript-eslint": "^8.24"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that we could give consumers more flexibility for this package given that sometimes new versions bump the peer dependency on typescript and some don't.

"eslint-plugin-jsdoc": "^50.2.4",
"typescript": ">=4.8.4 <5.6",
"typescript-eslint": "^8.24.0"
"typescript": ">=4.8.4 <5.9.0",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really trying not to inconvenience existing projects this time around...

Copy link
Copy Markdown
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README of @metamask/eslint-config-typescript as well to use the new version?

@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Mar 24, 2025

@Mrtenz Good call, done in 1e23503.

@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Mar 24, 2025

Should we upgrade TypeScript all around in this PR? I'm just updating the dev depependency in the eslint-config-typescript package to prove that we don't get any peer dependency warnings when doing so, but it just occurred to me I could also do it in the root package as well. You could argue it would be out of scope, though, so I wasn't sure.

@Mrtenz
Copy link
Copy Markdown
Member

Mrtenz commented Mar 24, 2025

Should we upgrade TypeScript all around in this PR? I'm just updating the dev depependency in the eslint-config-typescript package to prove that we don't get any peer dependency warnings when doing so, but it just occurred to me I could also do it in the root package as well. You could argue it would be out of scope, though, so I wasn't sure.

@mcmire Sounds good to me!

@mcmire
Copy link
Copy Markdown
Contributor Author

mcmire commented Mar 24, 2025

Feedback addressed. Ready for another review.

@mcmire mcmire enabled auto-merge (squash) April 15, 2025 21:12
@mcmire mcmire merged commit 3b2b537 into main Apr 15, 2025
25 checks passed
@mcmire mcmire deleted the bump-typescript branch April 15, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants