Fix: load_pc resize -> reserve#417
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PointCloud::load_pccallsresize(npoints)onpoints_local,intensities,and
timestamps, then appends real data withemplace_back. This creates2*npoints elements: first half zero-initialized, second half real data.
std::vector::resizevalue-initializes new elements, which for numeric types(
double,unsigned short) means zero.Why this bug is invisible
Phantom points have
[0, 0, 0]local coordinates andtimestamp == 0:and are reduced to one point. No practical effect.
timestamp == 0.0are filtered out whenskip_ts_0is enabled (export_laz.h:418-421). Phantom points never reachthe output file.
This bug affects only memory usage when point clouds are loaded without
downsampling.
Measurements
Dataset: 60.9M points, loaded without downsampling.
Fix
resize->reserveon 3 lines incore/src/point_cloud.cpp.