Skip to content

Add check to stop being able to drop whatever cluster data on scatterplot data #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulianThijssen merged 2 commits into from
Oct 27, 2025
Merged

Add check to stop being able to drop whatever cluster data on scatterplot data #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ed3bed
Add a check when dropping cluster data on a scatterplot to check whet…
JulianThijssen Oct 26, 2025
7eaefbc
Don't copy clusters when tallying
JulianThijssen Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions src/ScatterplotPlugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,30 @@ ScatterplotPlugin::ScatterplotPlugin(const PluginFactory* factory) :
});
}
else {

// Use the clusters set for points color
dropRegions << new DropWidget::DropRegion(this, "Color", description, "palette", true, [this, candidateDataset]() {
_settingsAction.getColoringAction().addColorDataset(candidateDataset);
_settingsAction.getColoringAction().setCurrentColorDataset(candidateDataset);
});
if (candidateDataset.isValid())
{
// Check to set whether the number of data points comprised throughout all clusters is the same number
// as the number of data points in the dataset we are trying to color
int totalNumIndices = 0;
for (const Cluster& cluster : candidateDataset->getClusters())
{
totalNumIndices += cluster.getIndices().size();
}

if (totalNumIndices == _positionDataset->getNumPoints())
{
// Use the clusters set for points color
dropRegions << new DropWidget::DropRegion(this, "Color", description, "palette", true, [this, candidateDataset]() {
_settingsAction.getColoringAction().addColorDataset(candidateDataset);
_settingsAction.getColoringAction().setCurrentColorDataset(candidateDataset);
});
}
else
{
// Number of indices in clusters doesn't match point dataset
dropRegions << new DropWidget::DropRegion(this, "Incompatible data", "Cluster data does not match number of data points", "exclamation-circle", false);
}
}
}
}
else {
Expand Down
Loading