Add check to stop being able to drop whatever cluster data on scatterplot data #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her its compatible
JulianThijssen
force-pushed
the
fix/cluster_drop_crash
branch
from
ceba4c7 to
5ed3bed
Compare
alxvth
requested changes
Oct 27, 2025
Contributor
alxvth
left a comment
alxvth
left a comment
There was a problem hiding this comment.
Good idea! We are doing the same checks for points, and should check here as well
alxvth
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You basically have free reign right now to drop whatever cluster dataset you want on top of whatever data you are visualizing in the scatterplot. It could be cluster data from a completely different dataset.
This fix adds at least a check whether the total number of indices contained in the clusters matches the data you are visualizing. Before it would crash.