Skip to content

mitlibwebsite gracefully handle missing og_description #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghukill merged 1 commit into from
Oct 7, 2025
Merged

mitlibwebsite gracefully handle missing og_description #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/sources/json/test_mitlibwebsite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,9 @@ def test_mitlibwebsite_get_summary_success():
assert MITLibWebsite.get_summary(source_record) == [
"Use this page to learn about different ways you can search the MIT Libraries' offerings." # noqa: E501
]


def test_mitlibwebsite_get_summary_returns_none_if_og_description_is_none():
source_record = create_mitlibwebsite_source_record_stub()
source_record["og_description"] = None
assert MITLibWebsite.get_summary(source_record) is None
6 changes: 4 additions & 2 deletions transmogrifier/sources/json/mitlibwebsite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,7 @@ def get_links(cls, source_record: dict) -> list[timdex.Link]:
return [timdex.Link(url=source_record["url"], kind="Website")]

@classmethod
def get_summary(cls, source_record: dict) -> list[str]:
return [source_record["og_description"]]
def get_summary(cls, source_record: dict) -> list[str] | None:
if og_description := source_record.get("og_description"):
return [og_description]
return None