mitlibwebsite gracefully handle missing og_description #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: The 'og_description' field can be 'None' in the source record, but we cannot set '[None]' in the output TIMDEXModel instance or we get validation errors. How this addresses that need: * If og_description is None, just return None Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-557 * related work
ehanson8
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
The
og_descriptionfield can beNonein the source record, but we cannot set[None]in the outputTIMDEXRecordinstance or we get validation errors.How this addresses that need:
og_descriptionisNone, just returnNoneHow can a reviewer manually see the effects of these changes?
The new test
test_mitlibwebsite_get_summary_returns_none_if_og_description_is_nonepretty succinctly shows the change.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?