Open
Conversation
added 5 commits
May 12, 2025 12:00
Author
|
For more details, please see the response this issue. |
Member
|
Thanks for the PR. Since PMC is downloaded during build so no need to remove the dependency for licensing issue. In other words, because we don't include PMC source code with our repo, GPL license is not an issue. I'll look at the MSVC compilation issue when I have time. |
Author
|
Hello, Thanks for your reply. I've addressed the MSVC issue in my PR by using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce WITH_PMC CMake option to conditionally disable the PMC dependency, aligning with the MIT license. This change also resolves compilation issues on Windows with the MSVC compiler.