Skip to content

Remove pmc dependency#7

Open
navidmahmoudian wants to merge 5 commits intoMIT-SPARK:masterfrom
navidmahmoudian:remove-pmc-dependency
Open

Remove pmc dependency#7
navidmahmoudian wants to merge 5 commits intoMIT-SPARK:masterfrom
navidmahmoudian:remove-pmc-dependency

Conversation

@navidmahmoudian
Copy link
Copy Markdown

Introduce WITH_PMC CMake option to conditionally disable the PMC dependency, aligning with the MIT license. This change also resolves compilation issues on Windows with the MSVC compiler.

@navidmahmoudian
Copy link
Copy Markdown
Author

For more details, please see the response this issue.

@jingnanshi
Copy link
Copy Markdown
Member

Thanks for the PR. Since PMC is downloaded during build so no need to remove the dependency for licensing issue. In other words, because we don't include PMC source code with our repo, GPL license is not an issue. I'll look at the MSVC compilation issue when I have time.

@navidmahmoudian
Copy link
Copy Markdown
Author

Hello,

Thanks for your reply. I've addressed the MSVC issue in my PR by using std::atomic within pkc.cpp. The unit tests are currently passing. Would you mind taking a look when you have a moment, or perhaps trying to compile and run the tests on your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants