Windows Build Error: Missing sys/time.h Header

[navidmahmoudian]

Hello,

I am encountering an issue while attempting to build the ROBIN project on a Windows environment. During the build process, I receive the following error:

Version MSBuild 17.12.12+1cce77968 pour .NET Framework

  1>Checking Build System
  Building Custom Rule D:/ROBIN/build/pmc-src/CMakeLists.txt
  pmc_heu.cpp
  pmc_maxclique.cpp
D:\ROBIN\build\pmc-src\include\pmc\pmc_graph.h(25,10): error C1083: Cannot open include file: 'sys/time.h': No such file or directory [D:\ROBIN\build\pmc-build\pmc.vcxproj]
  pmcx_maxclique.cpp
  (compiling source file '../pmc-src/pmc_heu.cpp')

D:\ROBIN\build\pmc-src\include\pmc\pmc_maxclique.h(24,10): error C1083: Cannot open include file: 'sys/time.h': No such file or directory [D:\ROBIN\build\pmc-build\pmc.vcxproj]
  (compiling source file '../pmc-src/pmc_maxclique.cpp')
...

As indicated in the error message, the sys/time.h header file is not found. My understanding is that the sys/time.h header is specific to POSIX-compliant operating systems and is not typically available in a standard Windows development environment.

Could you please advise on the recommended approach to build ROBIN on Windows? Are there alternative platform-specific implementations for the functionalities relying on sys/time.h, or are there specific build instructions or configurations I might be missing for Windows?

Thank you for your time and assistance in resolving this issue.

[carlsberg03]

This is because the author used the PMC , which includes some headers that are only supported on Unix systems (such as sys/time.h). Teaserpp has a similar issue, and someone has proposed a solution — you can refer to their implementation.
Alternatively, you can directly refactor pmc_utils.cpp to make it compatible with Windows — this part of the code, related to time and file handling, is relatively simple.
e.g.
origin pmc_utils.cpp

double get_time() {
    timeval t;
    gettimeofday(&t, NULL);
    return t.tv_sec*1.0 + t.tv_usec/1000000.0;
}

you can include windows.h and refactor it like

double get_time() {
    static LARGE_INTEGER frequency;
    static BOOL use_qpc = QueryPerformanceFrequency(&frequency);
    if (use_qpc) {
        LARGE_INTEGER now;
        QueryPerformanceCounter(&now);
        return (double)now.QuadPart / frequency.QuadPart;
    } else {
        return GetTickCount() / 1000.0;
    }
}

[navidmahmoudian]

Hello,

Thank you for your reply. Following up on our discussion, I have identified a significant issue regarding the licensing compatibility between ROBIN (MIT license) and its dependency PMC (GPL license). As you know, the inclusion of GPL-licensed code necessitates that the entire project adopting it must also be licensed under the GPL.

To resolve this, I've created a pull request that introduces an option, WITH_PMC, in the main CMakeLists.txt. This allows users to disable the PMC library during the build process. To maintain consistency with ROBIN's MIT license, the default value for this option is set to OFF.

Furthermore, this pull request includes modifications to enable successful compilation on Windows using MSVC. The key changes are:

1. Optional PMC Compilation: Introduced the WITH_PMC CMake option to exclude the PMC library.
2. std Atomic Operations: Replaced the GCC-specific atomic built-ins (__sync_fetch_and_add, __sync_fetch_and_sub) in pkc.cpp with their standard C++ equivalents from . This ensures compatibility with MSVC.
3. Improved Dependency Handling: Modified the main CMakeLists.txt to conditionally skip the download of external dependencies like Xenium if they are already present in the system (e.g., when using package managers like Conan on Windows).

In addition to these changes, I have a couple of questions regarding the current implementation:

1. In the robin::FindInlierStructure function, why is BZ_KCORE_SOLVER_MODE::BZ_SERIAL used instead of the parallel optimized (KCORE_SOLVER_MODE::PKC_PARALLEL_OPTIMIZED) or parallel (KCORE_SOLVER_MODE::PKC_PARALLEL) versions? It seems that utilizing the parallel implementations could potentially offer significant performance improvements. Is that correct?

2. Upon reviewing robin_test.cpp, I noticed a few inconsistencies:

• The test case TEST_CASE("3d reg large instance") does not contain any REQUIRE_THAT assertions to validate its outcome.
• Within the SECTION("large normal noise bound equivalence"), REQUIRE_THAT assertions are present for the max clique algorithm but are missing for the max core algorithm.

Finally, I strongly recommend that you verify the successful compilation of the provided code in your development environment and conduct thorough testing to ensure its expected functionality. Given the potential for platform-specific issues, we may need to iterate and revise the code further to ensure broad compatibility across different operating systems and environments. For instance, I encountered compilation errors on Ubuntu 24.04 (even without my modifications), as shown below:

[  3%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmc_heu.cpp.o
[  6%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmc_maxclique.cpp.o
[  9%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmcx_maxclique.cpp.o
[ 12%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmcx_maxclique_basic.cpp.o
[ 16%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmc_cores.cpp.o
[ 19%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmc_utils.cpp.o
[ 22%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmc_graph.cpp.o
[ 25%] Building CXX object pmc-build/CMakeFiles/pmc.dir/pmc_clique_utils.cpp.o
[ 29%] Linking CXX shared library libpmc.so
[ 29%] Built target pmc
[ 32%] Building CXX object CMakeFiles/robin.dir/src/core.cpp.o
[ 35%] Building CXX object CMakeFiles/robin.dir/src/graph.cpp.o
[ 38%] Building CXX object CMakeFiles/robin.dir/src/graph_core.cpp.o
[ 41%] Building CXX object CMakeFiles/robin.dir/src/graph_io.cpp.o
[ 45%] Building CXX object CMakeFiles/robin.dir/src/graph_solvers.cpp.o
/home/ROBIN/src/graph_solvers.cpp: In member function ‘std::vector<long unsigned int> robin::MaxCliqueSolver::FindMaxClique(const robin::IGraph&) const’:
/home/ROBIN/src/graph_solvers.cpp:64:3: error: ‘vector’ was not declared in this scope
   64 |   vector<int> edges;
      |   ^~~~~~
/home/ROBIN/src/graph_solvers.cpp:64:3: note: suggested alternatives:
In file included from /usr/include/c++/13/vector:66,
                 from /home/ROBIN/build/pmc-src/include/pmc/pmc_utils.h:25,
                 from /home/ROBIN/build/pmc-src/include/pmc/pmc_input.h:23,
                 from /home/ROBIN/build/pmc-src/include/pmc/pmc.h:24,
                 from /home/ROBIN/src/graph_solvers.cpp:7:
/usr/include/c++/13/bits/stl_vector.h:428:11: note:   ‘std::vector’
  428 |     class vector : protected _Vector_base<_Tp, _Alloc>
      |           ^~~~~~
/usr/include/c++/13/vector:86:13: note:   ‘std::pmr::vector’
   86 |       using vector = std::vector<_Tp, polymorphic_allocator<_Tp>>;
      |             ^~~~~~
/home/ROBIN/src/graph_solvers.cpp:64:10: error: expected primary-expression before ‘int’
   64 |   vector<int> edges;
      |          ^~~
/home/ROBIN/src/graph_solvers.cpp:65:10: error: expected primary-expression before ‘long’
   65 |   vector<long long> vertices;
      |          ^~~~
/home/ROBIN/src/graph_solvers.cpp:66:3: error: ‘vertices’ was not declared in this scope
   66 |   vertices.push_back(edges.size());
      |   ^~~~~~~~
/home/ROBIN/src/graph_solvers.cpp:66:22: error: ‘edges’ was not declared in this scope
   66 |   vertices.push_back(edges.size());
      |                      ^~~~~
/home/ROBIN/src/graph_solvers.cpp:103:10: error: expected primary-expression before ‘int’
  103 |   vector<int> C;
      |          ^~~
/home/ROBIN/src/graph_solvers.cpp:119:33: error: ‘C’ was not declared in this scope
  119 |     in.lb = maxclique.search(G, C);
      |                                 ^
/home/ROBIN/src/graph_solvers.cpp:125:18: error: expected primary-expression before ‘>’ token
  125 |     vector<size_t> C_result(C.begin(), C.end());
      |                  ^
/home/ROBIN/src/graph_solvers.cpp:125:29: error: ‘C’ was not declared in this scope
  125 |     vector<size_t> C_result(C.begin(), C.end());
      |                             ^
/home/ROBIN/src/graph_solvers.cpp:125:20: error: ‘C_result’ was not declared in this scope
  125 |     vector<size_t> C_result(C.begin(), C.end());
      |                    ^~~~~~~~
/home/ROBIN/src/graph_solvers.cpp:130:18: error: expected primary-expression before ‘>’ token
  130 |     vector<size_t> C_result(C.begin(), C.end());
      |                  ^
/home/ROBIN/src/graph_solvers.cpp:130:29: error: ‘C’ was not declared in this scope
  130 |     vector<size_t> C_result(C.begin(), C.end());
      |                             ^
/home/ROBIN/src/graph_solvers.cpp:130:20: error: ‘C_result’ was not declared in this scope
  130 |     vector<size_t> C_result(C.begin(), C.end());
      |                    ^~~~~~~~
/home/ROBIN/src/graph_solvers.cpp:147:30: error: ‘C’ was not declared in this scope
  147 |       finder.search_dense(G, C);
      |                              ^
/home/ROBIN/src/graph_solvers.cpp:150:24: error: ‘C’ was not declared in this scope
  150 |       finder.search(G, C);
      |                        ^
/home/ROBIN/src/graph_solvers.cpp:154:16: error: expected primary-expression before ‘>’ token
  154 |   vector<size_t> C_result(C.begin(), C.end());
      |                ^
/home/ROBIN/src/graph_solvers.cpp:154:27: error: ‘C’ was not declared in this scope
  154 |   vector<size_t> C_result(C.begin(), C.end());
      |                           ^
/home/ROBIN/src/graph_solvers.cpp:154:18: error: ‘C_result’ was not declared in this scope
  154 |   vector<size_t> C_result(C.begin(), C.end());
      |                  ^~~~~~~~
make[2]: *** [CMakeFiles/robin.dir/build.make:132: CMakeFiles/robin.dir/src/graph_solvers.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:14

I look forward to your feedback on the pull request and am ready to collaborate further to ensure the stability and portability of ROBIN.

Best regards,
Navid

[qza36]

Hi, I got the same compilation error on ubuntu24.04
'vector' was not declared in this scope
I solved this problem by adding using namespace std in ROBIN/src/graph_solvers.cpp