fix(react): Remove inline styles and wrapper markup from components#57
Merged
fix(react): Remove inline styles and wrapper markup from components#57
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove all inline
style={{}}attributes, hardcoded VA DS utility classes (vads-u-*), hardcoded CSS class names, and layout wrapper<div>elements from library components. Adddata-slotattributes as semantic styling hooks for consumers. The form system now outputs clean semantic HTML, leaving styling entirely to the consumer/VA Design System.Related Issues
Type of Change
expected)
Packages Affected
@formkit-gov/core@formkit-gov/react@formkit-gov/store@formkit-gov/wizard@formkit-gov/openapi@formkit-gov/validators@formkit-gov/test-utilsChecklist
Code Quality
Testing
Documentation
Changesets
pnpm changeset)Testing Instructions
pnpm install && pnpm test— all 1,280 tests passpnpm typecheck— no TypeScript errorspnpm lint— no new warningsgrep -r "style={{" packages/react/src/components/— zero results in library codeAdditional Notes
Breaking Changes
HTMLDivElementtoHTMLElement(wrapper div removed, list element is now root)<fieldset>border/padding now visible on AddressField (previously suppressed with inline styles)What was removed
style={{}}attributes from review, molecule, and form componentsvads-u-margin-y--2,vads-u-font-size--lg,vads-u-font-weight--bold,review-item,review-section,review-list<div>elements: ReviewSection header/children wrappers, ReviewList outer wrapper + inner li wrappers, AddressField state/zip flex containerWhat was added
data-slotattributes on all component elements as consumer styling hooksdata-list-styleattribute on ReviewList for list style variantclassNameprop onAddressFieldPropsandFullNameFieldProps