fix(storybook): Remove inline styles, upgrade Node to 22 LTS#58
Open
fix(storybook): Remove inline styles, upgrade Node to 22 LTS#58
Conversation
… LTS Remove all inline styles from 19 storybook story files so components render with VA DS default styling only. Update Node.js requirement from 20 to 22 LTS across .nvmrc, package.json engines, and all GitHub Actions workflows.
Update stale Node 20 references to 22 in CONTRIBUTING.md, SCOPE.md, and TESTING_STRATEGY.md. Improve Storybook story UX by wrapping debug output in collapsible details elements and using varied semantic HTML in WithCustomElements. Add changeset for engines.node bump.
The banner config does not work with splitting enabled — Rollup drops the directive during chunk generation, producing warnings on every build. Since all components use React hooks, consumers must already be in a client component context.
LinnJS
added
type: docs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nvmrc, andpackage.jsonengines<details>/<summary>, semantic HTML differentiation inWithCustomElementsengines.nodebump across all published packagesChanges
Inline Style Removal (20 story files)
<span>elements with semantic HTML (<strong>,<em>,<span>)<details>elementsNode 22 LTS Upgrade (6 config files)
.nvmrc: 20 → 22package.jsonengines:>=20.0.0→>=22.0.0Documentation Updates
CONTRIBUTING.md: Node >= 22.0.0docs/SCOPE.md: Node 22.x recommended, 20.x supported, 18.x droppeddocs/TESTING_STRATEGY.md: CI example updated to node-version: 22Test plan
pnpm lint— 0 errors (2 pre-existing warnings)pnpm typecheck— 0 errors across all 15 packagespnpm build— all 12 packages build successfullypnpm test— 1,280 tests pass, 0 failures