fix(core): Windows/Clang build, merge free pages after rollback, shell, warnings#185
Open
vkozio wants to merge 4 commits intoLadybugDB:masterfrom
Open
fix(core): Windows/Clang build, merge free pages after rollback, shell, warnings#185vkozio wants to merge 4 commits intoLadybugDB:masterfrom
vkozio wants to merge 4 commits intoLadybugDB:masterfrom
Conversation
…l, warnings (see PR description)
- ClientContext: add activeQueryCount, mtxForClose, cvForClose; registerQueryStart(), registerQueryEnd(), waitForNoActiveQuery(). - QueryProcessor::execute(): guard with registerQueryStart/End (RAII) so end is always called on exception. - Connection::~Connection(): call waitForNoActiveQuery() before setting preventTransactionRollbackOnDestruction and destroying clientContext. Avoids SIGSEGV when Connection is closed while workers still reference ClientContext (e.g. after TransactionManagerException during COPY or async close in Node addon).
…oint timeout - In ~Connection(), after waitForNoActiveQuery(), call transactionManager->rollback() when there is an active transaction, then set preventTransactionRollbackOnDestruction. - Ensures the transaction is removed from TransactionManager so Database::~Database() checkpoint does not time out (e.g. in PrivateApiTest.CloseConnectionWithActiveTransaction). - Add incident doc docs/incidents/2026-02-17-minimal-test-checkpoint-timeout.md (Resolved).
…der/planner sync with master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Fix core build on Windows with Clang; fix rollback/storage correctness; reduce warnings.
Changes
Attribution