fix(core): stability fixes integrated from RyuGraph and Kuzu#184
Open
vkozio wants to merge 2 commits intoLadybugDB:masterfrom
Open
fix(core): stability fixes integrated from RyuGraph and Kuzu#184vkozio wants to merge 2 commits intoLadybugDB:masterfrom
vkozio wants to merge 2 commits intoLadybugDB:masterfrom
Conversation
adsharma
changed the title
Contributor
|
@vkozio: thank you for the contribution! Please look into the test failures |
adsharma
reviewed
Feb 18, 2026
| nextHeaderPageIdx = page->nextHeaderPage; | ||
| }); | ||
| KU_ASSERT(headerPage); | ||
| numHeaders += headerPage->numHeaders; |
Contributor
There was a problem hiding this comment.
Would be good to have an explicit NULL check on headerPage here. KU_ASSERT is a nop on release builds.
KU_ASSERT is no-op in release builds; add runtime check and throw RuntimeException so release handles failed optimistic read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #106
Motivation
Improve core correctness and test coverage; attribution preserved for upstream.
Changes
Attribution
Suggested merge order for this and related PRs
Please merge in this order:
Branches 4–10 are built on top of 3, so merging out of order may cause duplicate or confusing diffs. The CI PR (11) is independent and can be skipped if you prefer to manage CI yourselves.