chore(tsconfig): enable stricter TypeScript compiler checks#735
Merged
ogazboiz merged 1 commit intoJun 2, 2026
Merged
Conversation
ogazboiz
approved these changes
Jun 2, 2026
Contributor
ogazboiz
left a comment
There was a problem hiding this comment.
clean — closes #652 (backend tsconfig enables noImplicitReturns / noUnusedLocals / noUnusedParameters across 19 files). all CI green. merging!
join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
Contributor
|
approved! but a couple of conflicting merges landed first and now this branch is DIRTY. quick rebase and it can land: git fetch upstream
git rebase upstream/main
git push --force-with-leasei'll auto-merge as soon as it's clean. |
This was referenced Jun 2, 2026
0ac04b8 to
5c58c64
Compare
Contributor
Author
|
@ogazboiz Done boss. Followed your instruction cleanly, please review then merge |
ogazboiz
approved these changes
Jun 2, 2026
Contributor
ogazboiz
left a comment
There was a problem hiding this comment.
clean — closes #652, stricter tsconfig (noImplicitReturns / noUnusedLocals / noUnusedParameters) enabled across 19 backend files. all CI green. merging!
join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #652
Changes made:
backend/tsconfig.json — Uncommented noImplicitReturns, noUnusedLocals, noFallthroughCasesInSwitch
Fixes for noImplicitReturns (TS7030):
Fixes for noUnusedLocals (TS6133):
Fixes for TS6196 (unused declaration):
npm run build passes clean. There were 10 test failures in stream-lifecycle.test.ts and they are pre-existing DB auth issues, not related to these changes (199 tests pass).