Skip to content

[Backend] sorobanService: drop second TransactionBuilder/Account/Networks import inside simulateContractCall#738

Open
EbukaMoses wants to merge 2 commits into
LabsCrypt:mainfrom
EbukaMoses:sorobanService_drop
Open

[Backend] sorobanService: drop second TransactionBuilder/Account/Networks import inside simulateContractCall#738
EbukaMoses wants to merge 2 commits into
LabsCrypt:mainfrom
EbukaMoses:sorobanService_drop

Conversation

@EbukaMoses
Copy link
Copy Markdown

Description

close #639

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #

Changes Made

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

Breaking Changes

Breaking Changes:

Migration Guide:

Screenshots/Demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

@ogazboiz
Copy link
Copy Markdown
Contributor

ogazboiz commented Jun 2, 2026

hey, main now has stricter TypeScript (#735 just merged) which exposes a real type issue:

src/services/sorobanService.ts: error TS2352:
  Conversion of type 'Hash' to type 'Uint8Array' may be a mistake
  because neither type sufficiently overlaps with the other.

addr.contractId() returns Hash (a soroban-sdk type), not Uint8Array directly. The fix is to double-cast through unknown:

new Uint8Array(addr.contractId() as unknown as ArrayBufferLike)

or use Buffer.from(addr.contractId()) if Hash has a toJSON / [Symbol.iterator]. Same change needed in both src/services/sorobanService.ts and src/workers/soroban-event-worker.ts.

once that's fixed plus a rebase on main, CI should clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backend] sorobanService: drop second TransactionBuilder/Account/Networks import inside simulateContractCall

2 participants