Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a955bb7
Let users set and see instrument nicknames instead of serial numbers
labkey-jeckels May 8, 2025
aad1bf3
Audit logging
labkey-jeckels May 8, 2025
02ec12b
Merge branch 'develop' into fb_instrumentNicknames
labkey-jeckels May 9, 2025
3d1014e
Finish adapting for SQLServer
labkey-jeckels May 9, 2025
311a593
SQL Server compatible SQL
labkey-jeckels May 9, 2025
ace4c72
Merge branch 'develop' into fb_instrumentNicknames
labkey-jeckels May 19, 2025
e10cf58
Fix exception report NPE
labkey-jeckels May 22, 2025
a65797d
Improve scoping
labkey-jeckels May 23, 2025
33da194
Clarify where nickname is saved
labkey-jeckels May 24, 2025
33326f9
Fix query for SQLServer
labkey-jeckels May 30, 2025
7df9b17
Add automated tests
labkey-jeckels Jun 4, 2025
e3e93e9
Update test/src/org/labkey/test/tests/targetedms/TargetedMSInstrument…
labkey-jeckels Jun 5, 2025
07134fb
Update test/src/org/labkey/test/tests/targetedms/TargetedMSInstrument…
labkey-jeckels Jun 5, 2025
370dcbc
Update test/src/org/labkey/test/tests/targetedms/TargetedMSInstrument…
labkey-jeckels Jun 5, 2025
f72bf18
Update test/src/org/labkey/test/tests/targetedms/TargetedMSInstrument…
labkey-jeckels Jun 5, 2025
a23f2eb
Update test/src/org/labkey/test/tests/targetedms/TargetedMSInstrument…
labkey-jeckels Jun 5, 2025
006eccf
Update test/src/org/labkey/test/tests/targetedms/TargetedMSInstrument…
labkey-jeckels Jun 5, 2025
c549917
Update test/src/org/labkey/test/tests/targetedms/TargetedMSInstrument…
labkey-jeckels Jun 5, 2025
99c3a6c
Remove unneeded method
labkey-jeckels Jun 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions resources/queries/targetedms/InstrumentSummaryByFolder.sql
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
SELECT
COUNT(ReplicateId.RunId) AS SkylineDocumentCount,
COUNT(DISTINCT ReplicateId.RunId) AS SkylineDocumentCount,
COUNT(DISTINCT ReplicateId) AS ReplicateCount,
MIN(AcquiredTime) AS FirstAcquisition,
MAX(AcquiredTime) AS LastAcquisition,
ReplicateId.RunId.Container,
InstrumentSerialNumber
InstrumentNickname
FROM targetedms.SampleFile
GROUP BY
ReplicateId.RunId.Container,
InstrumentSerialNumber
InstrumentNickname
2 changes: 2 additions & 0 deletions resources/queries/targetedms/QCInstrumentSummary.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
SELECT
sf.InstrumentNickname AS Nickname,
sf.InstrumentId.model AS InstrumentName,
sf.InstrumentSerialNumber AS SerialNumber,
MIN(sf.AcquiredTime) AS StartDate,
Expand All @@ -9,6 +10,7 @@ SELECT
FROM targetedms.SampleFile sf
INNER JOIN replicate rep ON sf.replicateId = rep.Id
GROUP BY
sf.InstrumentNickname,
sf.InstrumentSerialNumber,
sf.InstrumentId.model,
rep.runId
3 changes: 1 addition & 2 deletions resources/queries/targetedms/samplefile/.qview.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
<property name="columnTitle" value="Skyline Document"/>
</properties>
</column>
<column name="InstrumentId" />
<column name="InstrumentSerialNumber" />
<column name="InstrumentNickname" />
<column name="ModifiedTime" />
</columns>
<sorts>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
CREATE TABLE targetedms.InstrumentNickname
(
Id BIGSERIAL NOT NULL,

Container entityid NOT NULL,
Created TIMESTAMP,
CreatedBy USERID,
Modified TIMESTAMP,
ModifiedBy USERID,

SerialNumber VARCHAR(200),
Model VARCHAR(300),
Nickname VARCHAR(200),

CONSTRAINT PK_InstrumentNickname PRIMARY KEY (Id)
);
CREATE INDEX IDX_InstrumentNickname_Container ON targetedms.InstrumentNickname(Container);

18 changes: 18 additions & 0 deletions resources/schemas/dbscripts/sqlserver/targetedms-25.003-25.004.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
CREATE TABLE targetedms.InstrumentNickname
(
Id BIGINT IDENTITY(1, 1) NOT NULL,

Container entityid NOT NULL,
Created DATETIME,
CreatedBy USERID,
Modified DATETIME,
ModifiedBy USERID,

SerialNumber NVARCHAR(200),
Model NVARCHAR(300),
Nickname NVARCHAR(200),

CONSTRAINT PK_InstrumentNickname PRIMARY KEY (Id)
);
CREATE INDEX IDX_InstrumentNickname_Container ON targetedms.InstrumentNickname(Container);

13 changes: 13 additions & 0 deletions resources/schemas/targetedms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1920,4 +1920,17 @@
<column columnName="Container"/>
</columns>
</table>
<table tableName="InstrumentNickname" tableDbType="TABLE">
<columns>
<column columnName="Id"/>
<column columnName="Created"/>
<column columnName="CreatedBy"/>
<column columnName="Modified"/>
<column columnName="ModifiedBy"/>
<column columnName="Container"/>
<column columnName="SerialNumber"/>
<column columnName="Model"/>
<column columnName="Nickname"/>
</columns>
</table>
</tables>
Loading