Skip to content

Let users set and view nicknames for instruments instead of serial numbers#1072

Merged
labkey-jeckels merged 19 commits intodevelopfrom
fb_instrumentNicknames
Jun 6, 2025
Merged

Let users set and view nicknames for instruments instead of serial numbers#1072
labkey-jeckels merged 19 commits intodevelopfrom
fb_instrumentNicknames

Conversation

@labkey-jeckels
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels commented May 9, 2025

Rationale

Panorama shows instrument model and serial number when it's available in the Skyline document. However, users often refer to them by other names, like "QE1" and "QE2" for the first and second Q Exactive instruments acquired by a lab. We can improve usability by letting users assign nicknames.

Changes

  • For users with editor or higher access, let them set a nickname on the instrument details page
  • Show the nickname (or the model/serial number when no nickname is set) whenever we're referring to an instrument
  • Use Shared/Project/Current scoping so nicknames only need to be set once in any common deployment scenario

@labkey-tchad
Copy link
Copy Markdown
Member

This is currently broken on SQL Server

@labkey-jeckels labkey-jeckels marked this pull request as ready for review June 4, 2025 23:09
Copy link
Copy Markdown
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good. Just need to wait for page loads in a few places.

Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
Comment thread test/src/org/labkey/test/tests/targetedms/TargetedMSInstrumentNicknameTest.java Outdated
labkey-jeckels and others added 8 commits June 5, 2025 13:35
…NicknameTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>
…NicknameTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>
…NicknameTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>
…NicknameTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>
…NicknameTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>
…NicknameTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>
…NicknameTest.java

Co-authored-by: Trey Chadick <tchad@labkey.com>
@labkey-jeckels labkey-jeckels merged commit 315bf06 into develop Jun 6, 2025
8 of 9 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_instrumentNicknames branch June 6, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants