feat: Add Navigation Support for FindPackageShare and get_package_share_directory#63
Open
tibisabau wants to merge 1 commit intoKodo-Robotics:mainfrom
Open
feat: Add Navigation Support for FindPackageShare and get_package_share_directory#63tibisabau wants to merge 1 commit intoKodo-Robotics:mainfrom
tibisabau wants to merge 1 commit intoKodo-Robotics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements navigation support for
FindPackageShareandget_package_share_directoryfunctions in the LaunchMap parser. The parser now resolves these calls to actual filesystem paths using ROS 2'sament_index_python.packages.get_package_share_directory, while maintaining backward compatibility with the existing symbolic expression format.Implementation Details
package_path_resolver.pyutility module to handle package path resolution with graceful error handlingFindPackageSharehandler to includeresolved_pathfield in output when package is availableget_package_share_directoryresolver to return structured dict with both symbolic expression and resolved pathThe implementation gracefully handles cases where:
ament_index_pythonis not available (warns but continues)Closes #52.
Checklist if Applicable
npm run test:parser(94 passed, 1 skipped)npm run lint:py(All checks passed!)