Use new dissallow copy and move #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dzenanz Updates for remote package for LEGACY_REMOVE. |
Contributor
Author
|
@dzenanz Updates for a remote package for LEGACY_REMOVE. |
Member
|
I guess we need to fix the CI first, WIP here: #88 |
dzenanz
approved these changes
Jan 27, 2025
hjmjohnson
force-pushed
the
use-new-dissallow-copy-and-move
branch
3 times, most recently
from
b357b6f to
1516440
Compare
hjmjohnson
force-pushed
the
use-new-dissallow-copy-and-move
branch
from
1516440 to
d9d230b
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
|
This PR brings in 55 commits, which is probably not what we want. |
…acro Added two new macro's, intended to replace the old 'itkTypeMacro' and 'itkTypeMacroNoParent'. The main aim is to be clearer about what those macro's do: add a virtual 'GetNameOfClass()' member function and override it. Unlike 'itkTypeMacro', 'itkOverrideGetNameOfClassMacro' does not have a 'superclass' parameter, as it was not used anyway. Note that originally 'itkTypeMacro' did not use its 'superclass' parameter either, looking at commit 699b66cb04d410e555656828e8892107add38ccb, Will Schroeder, June 27, 2001: https://github.com/InsightSoftwareConsortium/ITK/blob/699b66cb04d410e555656828e8892107add38ccb/Code/Common/itkMacro.h#L331-L337
Clarifies that the macro does not just disallow copy and assign, but also move operations. Note that in this context, the term 'move' refers to both move-construct and move-assign. With this commit, the old macro name will remain available, as long as 'ITK_FUTURE_LEGACY_REMOVE = OFF' (which is the default).
HASI/include/itkLandmarkAtlasSegmentationFilter.hxx:44:26: warning: unused variable 'inputRegion' [-Wunused-variable] HASI/include/itkSegmentBonesInMicroCTFilter.hxx:326:25: warning: comparison of integers of different signs: 'PixelType' (aka 'short') and 'const unsigned int' [-Wsign-compare]
The convention of only specifying the MAJOR version is the indicator that the latest version in that series should be used. By not specifying the MINOR and PATCH, the exact versions is not pinned, but the latest in that series is chosen. (i.e. the v5 tag is updated every time a new MINOR or PATCH tag is generated). This allows benefiting from minor patch fixes without needing to update workflows.
Set the default build package tags to v5.4.2 for capturing the ITKRemoteModuleBuildTestPackageAction shared scripts. This pulls the default configuration items needed to build against ITK version v5.4.2.
dzenanz
force-pushed
the
use-new-dissallow-copy-and-move
branch
from
dbc289e to
6edf9d1
Compare
Member
|
I rebased this on master. |
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.