Skip to content

Conversation

@dzenanz
Copy link
Member

@dzenanz dzenanz commented Nov 25, 2024

No description provided.

@dzenanz dzenanz force-pushed the ci54 branch 2 times, most recently from fbd3c6f to 0cce230 Compare November 25, 2024 16:57
@dzenanz
Copy link
Member Author

dzenanz commented Nov 25, 2024

@thewtex Do you have an idea why Mac is failing? This is somewhere in the middle of the log (around line 837):

+ pushd IPP-tmp/
~/work/HASI/HASI/ITKBoneEnhancement/IPP-tmp ~/work/HASI/HASI/ITKBoneEnhancement
+ git checkout 830d14cc40199f438001ee493288139fb75bba92
HEAD is now at 830d14c ENH: Only extract required directories from the ITKPythonBuilds tar
+ git status
HEAD detached at 830d14c
+ popd
nothing to commit, working tree clean
+ rm -rf ITKPythonPackage/scripts/
~/work/HASI/HASI/ITKBoneEnhancement
+ cp -r IPP-tmp/scripts ITKPythonPackage/
+ rm -rf IPP-tmp/
+ sudo mkdir -p /Users/svc-dashboard/D/P
+ sudo chown 501: /Users/svc-dashboard/D/P
+ mv ITKPythonPackage /Users/svc-dashboard/D/P/
mv: rename ITKPythonPackage to /Users/svc-dashboard/D/P/ITKPythonPackage: Directory not empty
~/work/HASI/HASI
4.6G	./ITKBoneEnhancement

Namely, mv: rename ITKPythonPackage to /Users/svc-dashboard/D/P/ITKPythonPackage: Directory not empty looks worrying.

@dzenanz dzenanz requested a review from thewtex November 26, 2024 15:47
@dzenanz
Copy link
Member Author

dzenanz commented Nov 26, 2024

@jhlegarreta do you have an idea about Python package failure?

@jhlegarreta
Copy link

jhlegarreta commented Nov 26, 2024

@jhlegarreta do you have an idea about Python package failure?

CMake is erroring with the message No such module: "BoneEnhancement" at
https://github.com/KitwareMedical/HASI/actions/runs/12016048569/job/33495426326?pr=88#step:6:960

@dzenanz
Copy link
Member Author

dzenanz commented Nov 28, 2024

Even as-is, this is an improvement over status quo:
https://github.com/KitwareMedical/HASI/actions/runs/10752278369/job/29820413482

@dzenanz dzenanz marked this pull request as ready for review November 28, 2024 13:46
@jhlegarreta
Copy link

I'd at least love to see a commit message body.

@thewtex
Copy link
Contributor

thewtex commented Dec 11, 2024

@dzenanz BoneEnhancement needs to be added to the configuration:

CMake Error at /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/CMake/ITKModuleAPI.cmake:88 (message):
959
  No such module: "BoneEnhancement"
960
Call Stack (most recent call first):
961
  /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/CMake/ITKModuleAPI.cmake:7 (itk_module_load)
962
  /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/CMake/ITKModuleAPI.cmake:173 (_itk_module_use_recurse)
963
  /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/CMake/ITKModuleMacros.cmake:158 (itk_module_use)
964
  /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/CMake/ITKModuleExternal.cmake:171 (itk_module_impl)
965
  CMakeLists.txt:7 (include)

@dzenanz
Copy link
Member Author

dzenanz commented Dec 11, 2024

BoneEnhancement@e6935aa760c3fa4e247ca0f4924a4fe3e420bf91 is already in the configuration of the action. Where else does it need to be added?

@dzenanz
Copy link
Member Author

dzenanz commented Mar 10, 2025

Accomplished by #90.

@dzenanz dzenanz closed this Mar 10, 2025
@dzenanz dzenanz deleted the ci54 branch March 10, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants