implement support for cuboids in attachment#91
Open
oh-yes-0-fps wants to merge 1 commit intoKavrakiLab:mainfrom
Open
implement support for cuboids in attachment#91oh-yes-0-fps wants to merge 1 commit intoKavrakiLab:mainfrom
oh-yes-0-fps wants to merge 1 commit intoKavrakiLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add collision math for cuboids against other cuboids and capsules along with adding the ability for attachments to be composed of cuboids.
This has been tested in application.
The biggest flaw with the existing implementation is cuboids not supporting collision validation with pointclouds/CAPT obstacles. There should likely be proper warnings in documentation about this shortcoming or an implementation with cuboid vs CAPT for collision should be added.
In addition, to add capsule support for attachments would just need a good implementation of capsule vs capsule.