Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 53.32% 53.80% +0.48%
==========================================
Files 42 43 +1
Lines 1189 1221 +32
==========================================
+ Hits 634 657 +23
- Misses 555 564 +9
☔ View full report in Codecov by Sentry. |
Co-authored-by: Chad Scherrer <chad.scherrer@gmail.com>
|
Just to be sure I understand, it seems like static floats are working again with our interface, but ints are not, so you added special cases and dispatch patterns to handle this. Is that right? |
Yes, that's right - Static.jl v0.8 has static floats are But the approach in this PR seems to work. |
|
Ok now @theogf and @cscherrer ? |
|
We should still check MeasureTheory tests locally. Latest MT has Static = "0.5, 0.6"Does that mean this PR is technically a breaking change? |
No, AFAIK this is not considered breaking - none of the interfaces in MeasureBase.jl change. The fact the MeasureBase.jl depends on Static directly is a separate thing. It doesn't lead to code breaking, it only restricts which package versions are compatible. (It would be breaking if code that worked before, coupled with a Project.toml that specifies it's requirements, wouldn't work after a package update, but that won't happen. People might just not get the new version of MeasureBase.). |
But MeasureTheory doesn't even support MeasureBase v0.14 yet. |
|
Oh, I didn't realize it was so behind. Ok in that case let's go with this and then MT can catch up |
I'll see if I can do the Distributions extension soon, then MT can be updated in one go, maybe. |
Closes #99 and #111 .
Since StaticInt is no longer an
Integerin Static v0.8, we need to jump through a few hoops.Drops support for older versions of Static.jl.