Use StaticInteger instead of StaticInt and add tests for static util functions#116
Merged
Use StaticInteger instead of StaticInt and add tests for static util functions#116
Conversation
|
|
Collaborator
Author
|
Tests fixed. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 53.80% 54.05% +0.24%
==========================================
Files 43 43
Lines 1221 1221
==========================================
+ Hits 657 660 +3
+ Misses 564 561 -3
☔ View full report in Codecov by Sentry. |
theogf
approved these changes
May 30, 2023
Collaborator
theogf
left a comment
theogf
left a comment
There was a problem hiding this comment.
Nice, it just needs a version bump
cscherrer
approved these changes
May 30, 2023
Collaborator
Author
|
Added version bump. |
|
Collaborator
Author
|
Merci @theogf ! |
Collaborator
Author
|
Next on the agenda will the polishing up the transport framework and turning DistributionMeasures.jl into a MeasureBase.jl Pkg-extension (DistributionMeasures.jl itself will become deprecated). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #115 .
We should use
StaticIntegerinstead ofStaticIntfor argument types.Also adds tests for the new functions in static.jl.