Add git-tree-{sha1,sha256} (but only for .tar.gz downloads)#64
Merged
DilumAluthge merged 2 commits intoApr 19, 2026
Merged
Conversation
DilumAluthge
changed the title
git-tree-sha1), but only for tar.gz downloads
DilumAluthge
reviewed
Apr 6, 2026
| number_urls_success += 1 | ||
| println(stdout, " ✓") | ||
|
|
||
| if endswith(filename, ".dmg") |
Member
There was a problem hiding this comment.
Note: This content (lines 168 through 182) is not new. It used to exist on lines 199 through 213. We've just moved the existing content up (from line 199 to line 168).
We've moved it up so that we can use extension earlier.
DilumAluthge
reviewed
Apr 6, 2026
| end | ||
|
|
||
| # Build up metadata about this file | ||
| if endswith(filename, ".dmg") |
Member
There was a problem hiding this comment.
This content (lines 199 through 213) wasn't actually deleted. It was just moved up to line 168.
See also: #64 (comment)
DilumAluthge-LLM
force-pushed
the
codex/tarball-git-tree-sha1
branch
from
54d8e04 to
ebde551
Compare
DilumAluthge-LLM
changed the title
git-tree-sha1), but only for tar.gz downloads
DilumAluthge-LLM
changed the title
git-tree-sha1 (but only for .tar.gz downloads)
DilumAluthge-LLM
force-pushed
the
codex/tarball-git-tree-sha1
branch
from
ebde551 to
fe6305f
Compare
DilumAluthge
changed the title
git-tree-sha1 (but only for .tar.gz downloads)git-tree-{sha1,sha256} (but only for .tar.gz downloads)
DilumAluthge-LLM
force-pushed
the
codex/tarball-git-tree-sha1
branch
3 times, most recently
from
eb0ec54 to
e2550bf
Compare
DilumAluthge
force-pushed
the
codex/tarball-git-tree-sha1
branch
from
e2550bf to
a9e1141
Compare
Member
|
I have manually reviewed the code in this PR. |
Member
|
@IanButterworth or @fredrikekre Could you review this? |
Member
|
I want to merge #66 before I merge this, so I'll mark this as draft just to prevent accidental merging, but this PR is indeed ready to be reviewed. |
giordano
approved these changes
Apr 17, 2026
DilumAluthge
force-pushed
the
codex/tarball-git-tree-sha1
branch
from
690d021 to
8b4dcae
Compare
Co-authored-by: OpenAI Codex GPT-5 <codex@openai.com>
DilumAluthge
force-pushed
the
codex/tarball-git-tree-sha1
branch
from
8b4dcae to
55e3495
Compare
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds treehashes to
versions.json.git-tree-sha1andgit-tree-sha256), but only for.tar.gzfiles.julia-0.7.0-alpha-linux-i686.tar.gz) is bad (can't be extracted), so we manually skip it.Motivation
Julia releases (at least, the
tar.gzfiles) are almost artifacts:tar.gz).sha256of the tarball file inversions.json.The only thing missing is the
git-tree-sha1, which this PR adds. (Also, I went ahead and addedgit-tree-sha256, to future-proof us.)So, with this PR, I can treat a Julia release tarball as an artifact.
But even putting Artifacts aside, I think this is still useful to have, because it allows you to store Julia versions in a content-addressed way.
🤖 Generated by OpenAI Codex.