Revert "Add git-tree-{sha1,sha256} (but only for .tar.gz downloads)"#79
Closed
DilumAluthge wants to merge 2 commits into
Closed
Revert "Add git-tree-{sha1,sha256} (but only for .tar.gz downloads)"#79DilumAluthge wants to merge 2 commits into
git-tree-{sha1,sha256} (but only for .tar.gz downloads)"#79DilumAluthge wants to merge 2 commits into
Conversation
Member
Author
|
|
Member
Author
|
I went ahead and fixed the |
ararslan
approved these changes
Apr 28, 2026
Member
ararslan
left a comment
ararslan
left a comment
There was a problem hiding this comment.
Looks good to me, though I'm not familiar enough with JSON schemas to know what effect removing the fields from schema.json will have, if any.
Member
Author
|
Ah, you're right. I should keep it in the schema, albeit as an optional field. |
Member
Author
|
Closing in favor of #81 (which is narrower than this PR, but still accomplishes the main goal). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #64
This is only a temporary revert. Computing treehashes takes a long time, and now our build times are hitting GitHub's 6 hour time limit. So let's revert for now.
Once #67 has been merged, I'll reland this, because build times should be much better at that point.