Shape hierarchy#29
Open
Codyk12 wants to merge 4 commits into
Open
Conversation
…errors when shapes which are partially in the images are attempted to be drawn.
…g paths that went 'off image'
Contributor
Author
|
@timholy Would you mind merging this? |
johnnychen94
approved these changes
Aug 27, 2019
johnnychen94
left a comment
johnnychen94
left a comment
Member
There was a problem hiding this comment.
Since other PRs are based on this PR, this PR should be merged first. @timholy
Member
|
Some advice to your future PR. This PR has some changes related to #26, you can open another PR for that part. By doing this, others can easily find out and validate your changes. |
Member
|
Hmm, just noticed this. Let's see if it still passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded out the hierarchy for the drawable objects.