Thickness and In Bounds check - keyword args#31
Conversation
…errors when shapes which are partially in the images are attempted to be drawn.
…g paths that went 'off image'
johnnychen94
left a comment
johnnychen94
left a comment
There was a problem hiding this comment.
I like the idea here and it's a nice job; there's nothing much I can comment.
Can you add some tests to this new thickness keywords?
And don't forget to delete the .DS_Store file you uploaded 😄
|
To fix CI error on 1.0: # src/compat.jl
if v"1.0" <= VERSION < v"1.1"
isnothing(x) = x===nothing
end |
Codyk12
changed the title
johnnychen94
left a comment
johnnychen94
left a comment
There was a problem hiding this comment.
Thank you for your hard work, I'm getting to understand the code logic here :D
johnnychen94
left a comment
johnnychen94
left a comment
There was a problem hiding this comment.
Since #29 is a subset of this PR, I think it doesn't need to be merged?
|
|
||
| Overlays an image on an larger image. (x, y) is the center for placing the image | ||
| """ | ||
| struct ImageMap <: Drawable |
There was a problem hiding this comment.
What's the usage of this? I can't find anywhere this struct is used in your PR.
|
Are there any plans for merging this soon? My use case relies on thickness of lines and otherwise I'll have to fallback to using PIL with PyCall. |
|
We need to merge #29 first and rebase this PR on the top of that I'll see if that one is good to merge. |
|
Unfortunately, this library doesn't have the biggest community supporting it, so we decided to try to use another drawing library to use in the library we're making, hopefully, these features get put merged in soon though. |
4 participants
Added the ability to draw lines with a thickness