Skip to content

Fixup test filtering#770

Merged
maleadt merged 2 commits intomasterfrom
christiangnrd-patch-1
Mar 19, 2026
Merged

Fixup test filtering#770
maleadt merged 2 commits intomasterfrom
christiangnrd-patch-1

Conversation

@christiangnrd
Copy link
Member

Missed before merging #769

@christiangnrd
Copy link
Member Author

christiangnrd commented Mar 9, 2026

Assert tests now failing because of #767 (comment) instead of a typo.

Not sure what's up with the AMD and CUDA tests.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.95%. Comparing base (c1b651a) to head (7ab458e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   74.92%   74.95%   +0.02%     
==========================================
  Files          24       24              
  Lines        3781     3781              
==========================================
+ Hits         2833     2834       +1     
+ Misses        948      947       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christiangnrd christiangnrd mentioned this pull request Mar 9, 2026
@christiangnrd
Copy link
Member Author

Would successfully rebuilding this build make it the one that is used in the gnuassertr tests? It's only failing because the test passes but doesn't think it should since it's fetching a build that isn't tagged as 1.12.5 yet

@maleadt
Copy link
Member

maleadt commented Mar 10, 2026

Maybe; I retried it.

@christiangnrd christiangnrd force-pushed the christiangnrd-patch-1 branch 2 times, most recently from 4c8365a to 7ab458e Compare March 10, 2026 18:11
@christiangnrd
Copy link
Member Author

christiangnrd commented Mar 19, 2026

Maybe; I retried it.

Didn’t work :/

This can probably still be merged as-is and the assert build tests will probably fix themselves after the next commit to the release-1.12 julia branch

@maleadt maleadt merged commit 8811fef into master Mar 19, 2026
92 of 111 checks passed
@maleadt maleadt deleted the christiangnrd-patch-1 branch March 19, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants