Skip to content

Fix nightly#771

Draft
christiangnrd wants to merge 5 commits intomasterfrom
1.14
Draft

Fix nightly#771
christiangnrd wants to merge 5 commits intomasterfrom
1.14

Conversation

@christiangnrd
Copy link
Member

Includes #770

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/jlgen.jl b/src/jlgen.jl
index db3ab6e..0a97877 100644
--- a/src/jlgen.jl
+++ b/src/jlgen.jl
@@ -426,7 +426,7 @@ function GPUInterpreter(world::UInt=Base.get_world_counter();
                         opt_params::CC.OptimizationParams)
     @assert world <= Base.get_world_counter()
 
-    inf_cache = INFERENCE_CACHE_TYPE()
+        inf_cache = INFERENCE_CACHE_TYPE()
 
     return GPUInterpreter(world, method_table_view,
                           token, inf_cache,
@@ -437,7 +437,7 @@ function GPUInterpreter(interp::GPUInterpreter;
                         world::UInt=interp.world,
                         method_table_view::CC.MethodTableView=interp.method_table_view,
                         token::Any=interp.token,
-                        inf_cache::INFERENCE_CACHE_TYPE=interp.inf_cache,
+            inf_cache::INFERENCE_CACHE_TYPE = interp.inf_cache,
                         inf_params::CC.InferenceParams=interp.inf_params,
                         opt_params::CC.OptimizationParams=interp.opt_params)
     return GPUInterpreter(world, method_table_view,
diff --git a/src/reflection.jl b/src/reflection.jl
index ffffa8e..386327b 100644
--- a/src/reflection.jl
+++ b/src/reflection.jl
@@ -167,10 +167,10 @@ InteractiveUtils.code_warntype(err::KernelError; kwargs...) = code_warntype(err.
 struct jl_llvmf_dump
     TSM::LLVM.API.LLVMOrcThreadSafeModuleRef
     F::LLVM.API.LLVMValueRef
-@static if VERSION >= v"1.14.0-DEV.1823" # JuliaLang/julia#60698
-    dump::Ptr{Nothing}
-    jl_llvmf_dump(TSM::LLVM.API.LLVMOrcThreadSafeModuleRef, F::LLVM.API.LLVMValueRef) = new(TSM, F, C_NULL)
-end
+    @static if VERSION >= v"1.14.0-DEV.1823" # JuliaLang/julia#60698
+        dump::Ptr{Nothing}
+        jl_llvmf_dump(TSM::LLVM.API.LLVMOrcThreadSafeModuleRef, F::LLVM.API.LLVMValueRef) = new(TSM, F, C_NULL)
+    end
 end
 
 """
diff --git a/test/native.jl b/test/native.jl
index 4289c45..951dc17 100644
--- a/test/native.jl
+++ b/test/native.jl
@@ -304,7 +304,7 @@ end
 
     # breaking recursion in print_to_string makes it possible to compile
     # even in the presence of the above bug
-    # Native.code_llvm(devnull, Base.print_to_string, Tuple{Int,Int}; optimize=false)
+        # Native.code_llvm(devnull, Base.print_to_string, Tuple{Int,Int}; optimize=false)
 
     @test "We did not crash!" != ""
 end
diff --git a/test/native/precompile.jl b/test/native/precompile.jl
index a7f9b95..c2eaffc 100644
--- a/test/native/precompile.jl
+++ b/test/native/precompile.jl
@@ -76,7 +76,7 @@ precompile_test_harness("Inference caching") do load_path
         @test check_presence(square_mi, token)
 
         # check that identity survived
-        @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-rc1" || v"1.14.0-" <= VERSION < v"1.14.0-DEV.1843")
+        @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-rc1" || v"1.14.0-" <= VERSION < v"1.14.0-DEV.1843")
 
         GPUCompiler.clear_disk_cache!()
         @test GPUCompiler.disk_cache_enabled() == false
diff --git a/test/ptx/precompile.jl b/test/ptx/precompile.jl
index fb6910f..e670c78 100644
--- a/test/ptx/precompile.jl
+++ b/test/ptx/precompile.jl
@@ -49,6 +49,6 @@ precompile_test_harness("Inference caching") do load_path
         @test check_presence(kernel_mi, token)
 
         # check that identity survived
-        @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-rc1" || v"1.14.0-" <= VERSION < v"1.14.0-DEV.1843")
+        @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || v"1.13.0-" <= VERSION < v"1.13.0-rc1" || v"1.14.0-" <= VERSION < v"1.14.0-DEV.1843")
     end
 end

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.09%. Comparing base (c1b651a) to head (670e9d0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   74.92%   75.09%   +0.16%     
==========================================
  Files          24       24              
  Lines        3781     3782       +1     
==========================================
+ Hits         2833     2840       +7     
+ Misses        948      942       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# breaking recursion in print_to_string makes it possible to compile
# even in the presence of the above bug
Native.code_llvm(devnull, Base.print_to_string, Tuple{Int,Int}; optimize=false)
# Native.code_llvm(devnull, Base.print_to_string, Tuple{Int,Int}; optimize=false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable this test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a temporary commit I pushed to confirm that it was the source of the hang in the native testset on nightly. Any idea what could be causing the hang?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recursion triggering recursion during codegen? There's been inference cache changes, after all.

@christiangnrd christiangnrd marked this pull request as draft March 17, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants