Skip to content

Add show function to spans#222

Merged
kescobo merged 14 commits into
JuliaData:masterfrom
Paalon:show-span
Jul 1, 2024
Merged

Add show function to spans#222
kescobo merged 14 commits into
JuliaData:masterfrom
Paalon:show-span

Conversation

@Paalon
Copy link
Copy Markdown
Contributor

@Paalon Paalon commented Jun 20, 2024

Depends on #183. Add a show function to Span for debugging.
Shown as the following format:

(line, column) ∈ (10, 20)...(20, 10)

@Paalon Paalon mentioned this pull request Jun 22, 2024
@kescobo
Copy link
Copy Markdown
Member

kescobo commented Jun 25, 2024

#183 now merged - resolve conflicts and we can merge this too.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 29, 2024

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.20%. Comparing base (3b2b353) to head (505b204).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/span.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   87.19%   87.20%           
=======================================
  Files          15       15           
  Lines        1664     1665    +1     
=======================================
+ Hits         1451     1452    +1     
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Paalon
Copy link
Copy Markdown
Contributor Author

Paalon commented Jun 29, 2024

Now, conflicts are resolved.

@kescobo kescobo merged commit a440b9a into JuliaData:master Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants