Add objects to represent YAML versions.#224
Closed
Paalon wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I'll squash commits and comments in one. |
Here we use abstract type & subtyping because it's common traits pattern
in Julia.
We do not need to export these objects because we can use strings for
versions in user-facing functions like:
```julia
function load(str::AbstractString; version::YAMLVersion)
# ...
end
function load(str::AbstractString; version::AbstractString)
version == "1.1" ? load(str, version=YAMLV1_1()) :
version == "1.2" ? load(str, version=YAMLV1_2()) :
throw(ErrorException())
end
load(str, version="1.1")
```
Contributor
Author
|
Now squashed. |
Contributor
Author
GunnarFarneback
approved these changes
Jun 21, 2024
Member
|
OH, I think I did this out of order... |
Member
|
Gonna pause until monday, let me know if something has changed in the mean time |
Contributor
Author
|
The conflicts are inevitable. Not your fault. |
Contributor
Author
|
The commits in this PR are merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add objects to represent YAML versions for traits. For #198, #223.