Add peek1(::BufferedInput, ::Integer) as 1-based indexing peek function#209
Open
Paalon wants to merge 4 commits into
Open
Add peek1(::BufferedInput, ::Integer) as 1-based indexing peek function#209Paalon wants to merge 4 commits into
peek1(::BufferedInput, ::Integer) as 1-based indexing peek function#209Paalon wants to merge 4 commits into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 87.37% 87.52% +0.15%
==========================================
Files 12 12
Lines 1639 1547 -92
==========================================
- Hits 1432 1354 -78
+ Misses 207 193 -14 ☔ View full report in Codecov by Sentry. |
Paalon
changed the title
src/buffered_input.jl part 2peek1(::BufferedInput, ::Integer) as 1-based indexing peek function
kescobo
approved these changes
Jun 25, 2024
Member
kescobo
left a comment
kescobo
left a comment
There was a problem hiding this comment.
just need to resolve conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on #208. Prepare
peek1function for readability.