Open
Conversation
Feature/pure cmake
Loading EGL + GLES works, but rendering is black
Switch to using EGL
Indeed, we are runtime-finding OpenGL so no need to look for it in CMake. As we are only targeting Ubuntu 18.04 and up, let's use targets for Threads and Eigen
Feature/modernize cmake
Co-authored-by: Leo <35804463+Yuki-cpp@users.noreply.github.com>
Add option for orthographic projections to sim depth cameras
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #16 , I wanted to be able to run gl_depth_sim completely headlessly, namely inside of a docker container. The main blocker was the usage of GLFW, which requires a window and a context manager.
Thus, this PR aims at bringing in two main changes:
I also added a few bug fixes in ascentai#3 .
Let me know what you think of those changes!