Skip to content

fix: validation error SVG overflow in buildErrorResponse #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JhaSourav07 merged 3 commits into from
Jun 4, 2026
Merged

fix: validation error SVG overflow in buildErrorResponse #3556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
993e846
feat(i18n): add german translations
jatingow May 28, 2026
1800cc9
fix: validation error SVG overflow in buildErrorResponse
jatingow Jun 3, 2026
ea77056
fix: resolve merge conflicts with upstream
jatingow Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions app/api/streak/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,25 @@ type ParseResult = ReturnType<typeof streakParamsSchema.safeParse>;

function buildErrorResponse(error: unknown, parseResult: ParseResult): NextResponse {
const message = error instanceof Error ? error.message : String(error);
function buildInlineErrorSVG(text: string): string {
const MAX_LINE = 48;
const truncated = text.length > MAX_LINE * 2 ? text.slice(0, MAX_LINE * 2 - 1) + '…' : text;

const line1 = escapeSVGText(truncated.slice(0, MAX_LINE));
const line2 = truncated.length > MAX_LINE ? escapeSVGText(truncated.slice(MAX_LINE)) : null;

const textY = line2 ? '62' : '75';

return `<svg xmlns="http://www.w3.org/2000/svg" width="400" height="150" viewBox="0 0 400 150">
<rect width="400" height="150" fill="#2d0000" rx="8"/>
<text x="200" y="${textY}" text-anchor="middle" dominant-baseline="central" fill="#ffcccc" font-family="sans-serif" font-size="13">${line1}</text>${
line2
? `
<text x="200" y="91" text-anchor="middle" dominant-baseline="central" fill="#ffcccc" font-family="sans-serif" font-size="13">${line2}</text>`
: ''
}
</svg>`;
}

const isNotFound =
message.toLowerCase().includes('not found') ||
Expand Down Expand Up @@ -449,14 +468,7 @@ function buildErrorResponse(error: unknown, parseResult: ParseResult): NextRespo

// 3. Return a 400 Bad Request for Validation Errors
if (isValidationError) {
const validationSvg = `
<svg xmlns="http://www.w3.org/2000/svg" width="400" height="150">
<rect width="100%" height="100%" fill="#2d0000" rx="8"/>
<text x="50%" y="50%" text-anchor="middle" fill="#ffcccc" font-family="sans-serif">
${escapeSVGText(message)}
</text>
</svg>
`;
const validationSvg = buildInlineErrorSVG(message);

return new NextResponse(validationSvg, {
status: 400,
Expand All @@ -471,14 +483,7 @@ function buildErrorResponse(error: unknown, parseResult: ParseResult): NextRespo
// 4. Return a 500 Internal Server Error for real crashes
console.error('[streak] Unhandled error:', message);

const errorSvg = `
<svg xmlns="http://www.w3.org/2000/svg" width="400" height="150">
<rect width="100%" height="100%" fill="#2d0000" rx="8"/>
<text x="50%" y="50%" text-anchor="middle" fill="#ffcccc" font-family="sans-serif">
Something went wrong. Please try again later.
</text>
</svg>
`;
const errorSvg = buildInlineErrorSVG('Something went wrong. Please try again later.');

return new NextResponse(errorSvg, {
status: 500,
Expand Down
Loading