fix: validation error SVG overflow in buildErrorResponse#3556
Conversation
|
@jatingow is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Hey @jatingow, it looks like you didn't use our PR template! The section Please update your PR description to include all required sections so we can review this properly:
You can find the full template in CONTRIBUTING.md. Just edit your PR description and the |
|
Please pull the latest changes and resolve the conflicts so we can review it! git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-leaseOnce resolved, the |
|
🎉 Congratulations @jatingow! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #3467
The 400 and 500 error SVG templates in
buildErrorResponsehad three problems:viewBox(broken coordinate space)font-size(inherited browser default ~16px, too large)dominant-baseline(text misaligned vertically)Changes
buildInlineErrorSVG()helper with properviewBox,font-size="13",dominant-baseline="central", and 2-line truncationChecklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.